[action] [PR:16573] [Mellanox] Update spf test related to error status when sw control is enabled#19273
Closed
mssonicbld wants to merge 1 commit intosonic-net:202411from
Closed
[action] [PR:16573] [Mellanox] Update spf test related to error status when sw control is enabled#19273mssonicbld wants to merge 1 commit intosonic-net:202411from
mssonicbld wants to merge 1 commit intosonic-net:202411from
Conversation
… enabled (sonic-net#16573) * Update spf platform test related to error status, due to sonic-net/sonic-buildimage#20964 When software control is enabled, the port error status is as follows: 1. For active module, the expected state is OK 2. For cmis passive module, the expected state is ModuleLowPwr 3. For non cmis passive module, the expected state is 'Not supported' when software control is disabled, the port error status keep the original behaviour * fix issue caused by the vs * sfp test just run on physical setup * update sfp tests 1. For cmis passive module, when cmis ver is 3.0, the expected state is ModuleLowPwr, else it is OK
11 tasks
Collaborator
Author
|
Original PR: #16573 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Collaborator
|
Closing this PR as this PR(#19264) has all the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update spf platform test related to error status, due to PR: sonic-net/sonic-buildimage#20964
When software control is enabled, the port error status is as follows:
When software control is disabled, the port error status keeps the original behaviour
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update spf test related to error status when sw control is enabled
How did you do it?
When sw control is enabled, check the error stats as the following logic:
How did you verify/test it?
Run test_get_error_description and test_check_sfputil_error_status when sw control is enabled
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
Documentation