[Mellanox] Update spf test related to error status when sw control is enabled#19264
Merged
kperumalbfn merged 1 commit intosonic-net:202411from Jun 30, 2025
Merged
Conversation
… enabled (sonic-net#16573) * Update spf platform test related to error status, due to sonic-net/sonic-buildimage#20964 When software control is enabled, the port error status is as follows: 1. For active module, the expected state is OK 2. For cmis passive module, the expected state is ModuleLowPwr 3. For non cmis passive module, the expected state is 'Not supported' when software control is disabled, the port error status keep the original behaviour * fix issue caused by the vs * sfp test just run on physical setup * update sfp tests 1. For cmis passive module, when cmis ver is 3.0, the expected state is ModuleLowPwr, else it is OK
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Collaborator
|
Auto cherry-pick PR - #19273 |
prabhataravind
approved these changes
Jun 30, 2025
Contributor
prabhataravind
left a comment
prabhataravind
left a comment
There was a problem hiding this comment.
Approving cherry-pick as this is confirmed to fix the issue.
11 tasks
kperumalbfn
approved these changes
Jun 30, 2025
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Jul 1, 2025
… enabled (sonic-net#16573) (sonic-net#19264) [Mellanox] Update spf test related to error status when sw control is enabled
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Aug 2, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * fb53396 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250701:1725 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * 54633cb (base/202411) prabhataravind 250701:0928 - Add t1-28-lag and t1-48-lag to tests_mark_conditions.yaml (sonic-net#19274) | * 9a23c16 Cong Hou 250416:2355 - Align the sensors data for SN4280 with sonic-buildimage PR#21845 (sonic-net#17747) | * 8b2d2cd Jibin Bao 250306:0835 - add watchdog test data for x86_64-nvidia_sn4280-r0 (sonic-net#17312) | * 5c8d5f0 Jibin Bao 250701:0045 - [Mellanox] Update spf test related to error status when sw control is enabled (sonic-net#16573) (sonic-net#19264) | * 0bea309 Yawen 250411:1620 - add hwsku V64 (sonic-net#17897) | * 8ab9e6b zitingguo-ms 250628:1755 - [test_static_route] Skip PT0 neighbor when checking route redistribution (sonic-net#19226) | * 4276be3 prabhataravind 250627:1827 - Support t1-48-lag topo for acl tests (sonic-net#19236) | * e070035 Wenda Chu 250625:1719 - Skip multiple servers testbed parsing on branch 202411 (sonic-net#19158) | * 0e5645d xwjiang-ms 250625:1619 - Roll back ceos image version since it's causing bgp failure (sonic-net#19180) | * 7625d06 ganglv 250624:1548 - Fix configuration after gnmi test (sonic-net#19150) | * 25e2e55 zitingguo-ms 250624:2000 - [ACL] Record service ports individually and add them to the acl_table_ports (sonic-net#19168) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update spf platform test related to error status, due to PR: sonic-net/sonic-buildimage#20964
When software control is enabled, the port error status is as follows:
When software control is disabled, the port error status keeps the original behaviour
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update spf test related to error status when sw control is enabled
How did you do it?
When sw control is enabled, check the error stats as the following logic:
How did you verify/test it?
Run test_get_error_description and test_check_sfputil_error_status when sw control is enabled
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
Documentation