updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.#19163
Merged
yejianquan merged 4 commits intosonic-net:202505from Jun 26, 2025
Merged
updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.#19163yejianquan merged 4 commits intosonic-net:202505from
yejianquan merged 4 commits intosonic-net:202505from
Conversation
resolved the conflicts for test_link_drop.py
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
requested changes
Jun 24, 2025
Collaborator
lolyu
left a comment
There was a problem hiding this comment.
Looks you introduces some dirty changes into this PR, please update.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
approved these changes
Jun 25, 2025
Collaborator
lolyu
left a comment
There was a problem hiding this comment.
please use the same PR name as the original one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR refines test case behavior by removing redundant PTF fixture imports and implementing a more efficient skip logic for test files. It ensures that only test cases using PTF files import the fixture, reducing unnecessary overhead and improving pipeline clarity.
Cherry-pick of PR #18895
This is a backport of PR #18895 to the 202505 branch.
Type of change
Back port request
Approach
What is the motivation for this PR?
To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files.
How did you do it?
How did you verify/test it?
Any platform specific information?
No platform-specific changes.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A – This is a test case improvement and does not require documentation updates.