Skip to content

updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.#19163

Merged
yejianquan merged 4 commits intosonic-net:202505from
shanmukhakambala:fix-cherry-pick-202505
Jun 26, 2025
Merged

updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.#19163
yejianquan merged 4 commits intosonic-net:202505from
shanmukhakambala:fix-cherry-pick-202505

Conversation

@shanmukhakambala
Copy link
Copy Markdown
Contributor

@shanmukhakambala shanmukhakambala commented Jun 24, 2025

Description of PR

Summary:
This PR refines test case behavior by removing redundant PTF fixture imports and implementing a more efficient skip logic for test files. It ensures that only test cases using PTF files import the fixture, reducing unnecessary overhead and improving pipeline clarity.

Cherry-pick of PR #18895
This is a backport of PR #18895 to the 202505 branch.

Type of change

  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files.

How did you do it?

  • Audited test cases to identify those importing the PTF fixture without using it.
  • Removed the fixture from those test cases.
  • Added logic to skip tests gracefully when PTF is not applicable.

How did you verify/test it?

  • Verified that only relevant tests import the PTF fixture and others are skipped cleanly.

Any platform specific information?

No platform-specific changes.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A – This is a test case improvement and does not require documentation updates.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks you introduces some dirty changes into this PR, please update.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@shanmukhakambala shanmukhakambala requested a review from lolyu June 25, 2025 06:02
Copy link
Copy Markdown
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the same PR name as the original one

@shanmukhakambala shanmukhakambala changed the title Fix cherry pick 202505 updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/. Jun 25, 2025
@yejianquan yejianquan merged commit 0c70e83 into sonic-net:202505 Jun 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants