updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/. by shanmukhakambala · Pull Request #18895 · sonic-net/sonic-mgmt

shanmukhakambala · 2025-06-10T05:46:19Z

Description of PR

Summary:
This PR refines test case behavior by removing redundant PTF fixture imports and implementing a more efficient skip logic for test files. It ensures that only test cases using PTF files import the fixture, reducing unnecessary overhead and improving pipeline clarity.

Fixes # (issue)
N/A

Type of change

Test case improvement

Back port request

Approach

What is the motivation for this PR?

To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files.

How did you do it?

Audited test cases to identify those importing the PTF fixture without using it.
Removed the fixture from those test cases.
Added logic to skip tests gracefully when PTF is not applicable.

How did you verify/test it?

Verified that only relevant tests import the PTF fixture and others are skipped cleanly.

Any platform specific information?

No platform-specific changes.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A – This is a test case improvement and does not require documentation updates.

mssonicbld · 2025-06-10T05:46:26Z

/azp run

azure-pipelines · 2025-06-10T05:46:32Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-06-10T06:36:36Z

/azp run

azure-pipelines · 2025-06-10T06:36:41Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

StormLiangMS

LGTM

StormLiangMS · 2025-06-11T08:40:40Z

hi @shanmukhakambala could you address the conflict?

mssonicbld · 2025-06-11T10:23:55Z

/azp run

azure-pipelines · 2025-06-11T10:24:01Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

resolved the conflicts for test_link_drop.py

Resolved the conflicts

mssonicbld · 2025-06-12T06:27:13Z

/azp run

azure-pipelines · 2025-06-12T06:27:25Z

Azure Pipelines successfully started running 1 pipeline(s).

.pre-commit-config.yaml

mssonicbld · 2025-06-12T10:06:53Z

/azp run

azure-pipelines · 2025-06-12T10:07:06Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/dualtor_io/test_grpc_server_failure.py

mssonicbld · 2025-06-13T06:43:06Z

/azp run

azure-pipelines · 2025-06-13T06:43:19Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-13T06:52:04Z

/azp run

azure-pipelines · 2025-06-13T06:52:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-16T03:58:57Z

@shanmukhakambala PR conflicts with 202505 branch

Description of PR Summary: This PR refines test case behavior by removing redundant PTF fixture imports and implementing a more efficient skip logic for test files. It ensures that only test cases using PTF files import the fixture, reducing unnecessary overhead and improving pipeline clarity. Cherry-pick of PR #18895 This is a backport of PR #18895 to the 202505 branch. Type of change Test case improvement Approach What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. co-authorized by: jianquanye@microsoft.com

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes.

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes.

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes. Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…c-net#18895) What is the motivation for this PR? To reduce pipeline noise and prevent PR checker failures caused by unnecessary PTF fixture imports in test cases that do not use PTF files. How did you do it? Audited test cases to identify those importing the PTF fixture without using it. Removed the fixture from those test cases. Added logic to skip tests gracefully when PTF is not applicable. How did you verify/test it? Verified that only relevant tests import the PTF fixture and others are skipped cleanly. Any platform specific information? No platform-specific changes.

lolyu approved these changes Jun 10, 2025

View reviewed changes

StormLiangMS previously approved these changes Jun 11, 2025

View reviewed changes

shanmukhakambala dismissed StormLiangMS’s stale review via 520fb21 June 11, 2025 10:23

shanmukhakambala added 3 commits June 12, 2025 05:49

updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.

1133417

added missed file

dfca443

resolved the conflicts for test_link_drop.py

updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/.

38f7575

Resolved the conflicts

shanmukhakambala force-pushed the skipdualtorptf branch from 520fb21 to 38f7575 Compare June 12, 2025 06:27

StormLiangMS reviewed Jun 12, 2025

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

Merge branch 'sonic-net:master' into skipdualtorptf

d4182a7

lolyu reviewed Jun 12, 2025

View reviewed changes

tests/dualtor_io/test_grpc_server_failure.py Outdated Show resolved Hide resolved

Upgrading the Py modules

f04e329

updated

7ae36d8

StormLiangMS approved these changes Jun 15, 2025

View reviewed changes

StormLiangMS merged commit 748369e into sonic-net:master Jun 15, 2025
12 checks passed

StormLiangMS added the Request for 202505 branch label Jun 15, 2025

yejianquan added the Approved for 202505 branch label Jun 16, 2025

mssonicbld added the Cherry Pick Conflict_202505 label Jun 16, 2025

shanmukhakambala mentioned this pull request Jun 25, 2025

updated testcase under dualtor/, dualtor_io/ and dualtor_mgmt/. #19163

Merged

7 tasks

yejianquan added Included in 202505 branch and removed Cherry Pick Conflict_202505 labels Jun 26, 2025

Conversation

shanmukhakambala commented Jun 10, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jun 10, 2025

Uh oh!

azure-pipelines bot commented Jun 10, 2025

Uh oh!

mssonicbld commented Jun 10, 2025

Uh oh!

azure-pipelines bot commented Jun 10, 2025

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

StormLiangMS commented Jun 11, 2025

Uh oh!

mssonicbld commented Jun 11, 2025

Uh oh!

azure-pipelines bot commented Jun 11, 2025

Uh oh!

mssonicbld commented Jun 12, 2025

Uh oh!

azure-pipelines bot commented Jun 12, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 12, 2025

Uh oh!

azure-pipelines bot commented Jun 12, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 13, 2025

Uh oh!

azure-pipelines bot commented Jun 13, 2025

Uh oh!

mssonicbld commented Jun 13, 2025

Uh oh!

azure-pipelines bot commented Jun 13, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants