[action] [PR:19071] voqWD disabling and method to check dshellClient is running#19124
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jun 22, 2025
Merged
Conversation
…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)
9 tasks
Collaborator
Author
|
Original PR: #19071 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Disabling voqWD in testcase where PFCWD is disabled and traffic is run for more than 1min. Added a method to check if dshell client is up and running
Summary:
Fixes #
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map0] - Failed: Losses observed in lossy traffic streamsType of change
Back port request
Approach
What is the motivation for this PR?
We had added the fixture to disable the voqWD.
sonic-mgmt/tests/snappi_tests/pfcwd/test_pfcwd_actions.py
Line 18 in 939485f
But every tests does config reload on the DUT’s which reverses disabled voqWD config.
Hence the test was failing
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map0] - Failed: Losses observed in lossy traffic streamsWe had added the fixture to disable the voqWD.
config reload done as part of teardown:
sonic-mgmt/tests/snappi_tests/pfcwd/test_pfcwd_actions.py
Line 885 in 939485f
How did you do it?
Disabling the voqWD in the test case where PFCWD is disabled and traffic is sent for > 1min
How did you verify/test it?
Manually ran the tests with change
Any platform specific information?
Cisco8000