voqWD disabling and method to check dshellClient is running by shwnaik · Pull Request #19071 · sonic-net/sonic-mgmt

shwnaik · 2025-06-17T23:06:06Z

Description of PR

Disabling voqWD in testcase where PFCWD is disabled and traffic is run for more than 1min. Added a method to check if dshell client is up and running

Summary:
Fixes #
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map0] - Failed: Losses observed in lossy traffic streams

Type of change

Bug fix
Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
[X ] Test case improvement

Back port request

Approach

What is the motivation for this PR?

We had added the fixture to disable the voqWD.

sonic-mgmt/tests/snappi_tests/pfcwd/test_pfcwd_actions.py

Line 18 in 939485f

    
           from tests.snappi_tests.cisco.helper import disable_voq_watchdog               # noqa: F401

But every tests does config reload on the DUT’s which reverses disabled voqWD config.
Hence the test was failing
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map0] - Failed: Losses observed in lossy traffic streamsWe had added the fixture to disable the voqWD.

config reload done as part of teardown:

sonic-mgmt/tests/snappi_tests/pfcwd/test_pfcwd_actions.py

Line 885 in 939485f

config_reload(sonic_host=duthost, config_source='config_db', safe_reload=True)

How did you do it?

Disabling the voqWD in the test case where PFCWD is disabled and traffic is sent for > 1min

How did you verify/test it?

Manually ran the tests with change

========================= short test summary info =========================================
PASSED snappi_tests/pfcwd/test_pfcwd_a2a_with_snappi.py::test_multidut_pfcwd_all_to_all[multidut_port_info0-True]
PASSED snappi_tests/pfcwd/test_pfcwd_a2a_with_snappi.py::test_multidut_pfcwd_all_to_all[multidut_port_info0-False]
PASSED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_drop_90_10[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_drop_uni[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_drop_over_subs_40_09[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-True]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-False]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-True]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio[multidut_port_info0-False]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_reboot[multidut_port_info0-cold-yy40-mixed-rp|4-True]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-True]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_reboot[multidut_port_info0-cold-False]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-True-swss]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio_service_restart[multidut_port_info0-False-swss]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-True-swss]
PASSED snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py::test_pfcwd_basic_multi_lossless_prio_restart_service[multidut_port_info0-False-swss]
PASSED snappi_tests/pfcwd/test_pfcwd_burst_storm_with_snappi.py::test_pfcwd_burst_storm_single_lossless_prio[multidut_port_info0]
PASSED snappi_tests/pfcwd/test_pfcwd_m2o_with_snappi.py::test_pfcwd_many_to_one[multidut_port_info0-True]
PASSED snappi_tests/pfcwd/test_pfcwd_m2o_with_snappi.py::test_pfcwd_many_to_one[multidut_port_info0-False]
PASSED snappi_tests/pfcwd/test_pfcwd_mixed_speed.py::test_mixed_speed_pfcwd_enable[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_mixed_speed.py::test_mixed_speed_pfcwd_disable[multidut_port_info0-port_map0]
PASSED snappi_tests/pfcwd/test_pfcwd_runtime_traffic_with_snappi.py::test_pfcwd_runtime_traffic[multidut_port_info0]
SKIPPED [2] snappi_tests/pfcwd/test_pfcwd_actions.py:370: Forward action is not supported in cisco-8000.
SKIPPED [1] common/helpers/assertions.py:22: Need Minimum of 2 ports defined in ansible/files/*links.csv file
SKIPPED [2] snappi_tests/pfcwd/test_pfcwd_actions.py:715: Forward action is not supported in cisco-8000.
SKIPPED [1] snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py:141: Reboot type warm is not supported on cisco-8000 switches
SKIPPED [1] snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py:141: Reboot type fast is not supported on cisco-8000 switches
SKIPPED [2] snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py:190: Reboot type warm is not supported on cisco-8000 switches
SKIPPED [2] snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py:190: Reboot type fast is not supported on cisco-8000 switches
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_drop_90_10[multidut_port_info0-port_map1] - Failed: Rx Ports for yy40-mixed-tb in MULTIDUT_PORT_INFO doesn't match with ansible/files/*links.csv
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_drop_uni[multidut_port_info0-port_map1] - Failed: Rx Ports for yy40-mixed-tb in MULTIDUT_PORT_INFO doesn't match with ansible/files/*links.csv
FAILED snappi_tests/pfcwd/test_pfcwd_actions.py::test_pfcwd_disable_pause_cngtn[multidut_port_info0-port_map1] - Failed: Rx Ports for yy40-mixed-tb in MULTIDUT_PORT_INFO doesn't match with ansible/files/*links.csv
=========== 3 failed, 23 passed, 11 skipped, 22 warnings in 17703.22s (4:55:03) ===================

Any platform specific information?

Cisco8000

…n for more than 1min. Added a method to check if dshell client is up and running

mssonicbld · 2025-06-17T23:06:13Z

/azp run

azure-pipelines · 2025-06-17T23:06:25Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang

lgtm

sdszhang · 2025-06-20T00:37:07Z

@shwnaik can you resolve the conflict?

…test_streams

mssonicbld · 2025-06-20T22:48:52Z

/azp run

azure-pipelines · 2025-06-20T22:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

mssonicbld · 2025-06-21T09:57:30Z

Cherry-pick PR to 202505: #19124

mssonicbld · 2025-06-21T09:57:37Z

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#435

…n for more than 1min. Added a method to check if dshell client is up and running (#19071)

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071) Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

d71cd16

…n for more than 1min. Added a method to check if dshell client is up and running

sdszhang approved these changes Jun 18, 2025

View reviewed changes

sdszhang added Request for msft-202405 Branch Request for 202505 branch labels Jun 18, 2025

bpar9 previously approved these changes Jun 20, 2025

View reviewed changes

Merge branch 'master' of github.com:shwnaik/sonic-mgmt into multiple_…

52c6da6

…test_streams

shwnaik dismissed bpar9’s stale review via 52c6da6 June 20, 2025 22:48

bpar9 approved these changes Jun 20, 2025

View reviewed changes

bpar9 merged commit 5e7b0b8 into sonic-net:master Jun 20, 2025
10 checks passed

yejianquan added Approved for msft-202405 Branch Approved for 202505 branch labels Jun 21, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 21, 2025

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

bcae91c

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

mssonicbld added the Created PR to 202505 branch label Jun 21, 2025

This was referenced Jun 21, 2025

[action] [PR:19071] voqWD disabling and method to check dshellClient is running Azure/sonic-mgmt.msft#435

Merged

[action] [PR:19071] voqWD disabling and method to check dshellClient is running #19124

Merged

mssonicbld added the Created PR to msft-202405 Branch label Jun 21, 2025

mssonicbld added Included in msft-202405 Branch and removed Created PR to msft-202405 Branch labels Jun 21, 2025

mssonicbld pushed a commit that referenced this pull request Jun 22, 2025

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

d0053de

…n for more than 1min. Added a method to check if dshell client is up and running (#19071)

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jun 22, 2025

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

37d127a

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

2d5ba8d

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026

Disabling voqWD in testcase where PFCWD is disabled and traffic is ru…

8410d6a

…n for more than 1min. Added a method to check if dshell client is up and running (sonic-net#19071)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

voqWD disabling and method to check dshellClient is running#19071

voqWD disabling and method to check dshellClient is running#19071
bpar9 merged 2 commits intosonic-net:masterfrom
shwnaik:Losses_observed_lossy_traffic

shwnaik commented Jun 17, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Jun 17, 2025

Uh oh!

azure-pipelines bot commented Jun 17, 2025

Uh oh!

sdszhang left a comment

Uh oh!

sdszhang commented Jun 20, 2025

Uh oh!

mssonicbld commented Jun 20, 2025

Uh oh!

azure-pipelines bot commented Jun 20, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 21, 2025

Uh oh!

mssonicbld commented Jun 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

shwnaik commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Uh oh!

mssonicbld commented Jun 17, 2025

Uh oh!

azure-pipelines bot commented Jun 17, 2025

Uh oh!

sdszhang left a comment

Choose a reason for hiding this comment

Uh oh!

sdszhang commented Jun 20, 2025

Uh oh!

mssonicbld commented Jun 20, 2025

Uh oh!

azure-pipelines bot commented Jun 20, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 21, 2025

Uh oh!

mssonicbld commented Jun 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shwnaik commented Jun 17, 2025 •

edited

Loading