[action] [PR:18267] Shutdown BGP for PCBB tests instead of stopping processes

[mssonicbld]

Description of PR

Summary:

When running test_tunnel_qos_remap.py, the BGP bgpmon and bgpd service stop and start hacking does not correctly bring BGP back up on Cisco-8000 devices. Modify shutdown/startup to match QOS SAI's test fixtures, as revised by PR #15108.

Note that this only causes issues with BGP if the syncd swap is not performed (i.e. it's already loaded and --qos_swap_syncd is set to False). If the swap is performed, then the entire config is reloaded, which masks the fact that BGP didn't come back up correctly.

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• New Test case
• Skipped for non-supported platforms
• Test case improvement

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405
• 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Validated on dualtor-aa Cisco-8000 that BGP comes back up after running test_tunnel_qos_remap.py xoff test cases.
Ran without doing dynamic syncd container swap, per above note about this masking the BGP issue.
Output after test pass shown here as sessions are up for 39 seconds.

root@tor-dut-1:/home/cisco# show ip bgp sum

IPv4 Unicast Summary:
BGP router identifier 10.1.0.33, local AS number 65100 vrf-id 0
BGP table version 32014
RIB entries 12809, using 1639552 bytes of memory
Peers 4, using 82368 KiB of memory
Peer groups 4, using 256 bytes of memory


Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName
----------- --- ----- --------- --------- -------- ----- ------ --------- -------------- --------------
10.0.1.57 4 64600 6501 6502 32014 0 0 00:00:39 6402 ARISTA01T1
10.0.1.59 4 64600 6501 6503 32014 0 0 00:00:39 6402 ARISTA02T1
10.0.1.61 4 64600 6501 6503 32014 0 0 00:00:39 6402 ARISTA03T1
10.0.1.63 4 64600 6501 6503 32014 0 0 00:00:39 6402 ARISTA04T1

Total number of neighbors 4

Any platform specific information?

Test on Cisco-8000, but affects code-path for all vendors. Now matches procedure in qos_sai_base.py.

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

Original PR: #18267

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).