Update the way of shutdown bgp service in qos sai test#15108
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Dec 11, 2024
Merged
Update the way of shutdown bgp service in qos sai test#15108liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Update the way of shutdown bgp service in qos sai test In MSN2700 T0 setup, the original way of setting bgp down would be too slow And the bgp routes would be delay handled after several minutes, it would affect the qos buffer test result
Collaborator
|
@XuChen-MSFT Can you help review? |
nhe-NV
approved these changes
Dec 5, 2024
liat-grozovik
approved these changes
Dec 11, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 13, 2025
- What is the motivation for this PR? The original way of setting bgp down would be too slow especially for CPUs which are not that strong. And the bgp routes would be delay handled after several minutes, it would affect the qos buffer test result - How did you do it? Use bgp shutdown/start to control bgp - How did you verify/test it? Run it in internal regression
Collaborator
|
Cherry-pick PR to 202411: #16473 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 13, 2025
- What is the motivation for this PR? The original way of setting bgp down would be too slow especially for CPUs which are not that strong. And the bgp routes would be delay handled after several minutes, it would affect the qos buffer test result - How did you do it? Use bgp shutdown/start to control bgp - How did you verify/test it? Run it in internal regression
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
11 tasks
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update the way of shutdown bgp service in qos sai test
The original way of setting bgp down would be too slow especially for CPUs which are not that strong.
And the bgp routes would be delay handled after several minutes, it would affect the qos buffer test result
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The original way of setting bgp down would be too slow especially for CPUs which are not that strong.
And the bgp routes would be delay handled after several minutes, it would affect the qos buffer test result
How did you do it?
Use bgp shutdown/start to control bgp
How did you verify/test it?
Run it in internal regression
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation