Skip to content

Fix the import issue in pfc_asym.py#1896

Merged
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-pfc-asym-import
Jul 15, 2020
Merged

Fix the import issue in pfc_asym.py#1896
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:fix-pfc-asym-import

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Jul 14, 2020

Description of PR

Summary:
Fixes # (issue)
Fix the import issue in pfc_asym.py introduced in #1879

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

PR #1879 accidentally introduced an import issue.

How did you do it?

Update from common.helpers.generators import generate_ips to from tests.common.helpers.generators import generate_ips

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin wangxin requested a review from a team July 14, 2020 03:15
@wangxin
Copy link
Collaborator Author

wangxin commented Jul 14, 2020

retest vsimage please

@wangxin
Copy link
Collaborator Author

wangxin commented Jul 15, 2020

retest this please

2 similar comments
@wangxin
Copy link
Collaborator Author

wangxin commented Jul 15, 2020

retest this please

@wangxin
Copy link
Collaborator Author

wangxin commented Jul 15, 2020

retest this please

@wangxin wangxin merged commit 8337090 into sonic-net:master Jul 15, 2020
@wangxin wangxin deleted the fix-pfc-asym-import branch July 20, 2020 08:58
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
901e2efb4f5c6a1179068b43e6a837dfff19d9d9 (HEAD -> 201911, origin/201911) [fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606)
6c6f4fbbeb24b6e16a2bffdee760ba6a95e2ceb3 configure extra inc/lib directory for build (sonic-net#1247)
cccb59efa031b817c1936a74db969debbb9b2775 [201911][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1896)
62dc36d9da988807c7a397fd90ac2859a5a07699 [ci]: Support Azure pipelines on 201911 branch (sonic-net#1806)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants