[interface.yml] Raise the failures again in the rescue blocks#1247
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 2, 2019
wangxin:fix-rescue
Merged
[interface.yml] Raise the failures again in the rescue blocks#1247lguohan merged 1 commit intosonic-net:masterfrom wangxin:fix-rescue
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:fix-rescue
Conversation
Fix issue #1244 Signed-off-by: Xin Wang <[email protected]>
lguohan
approved these changes
Dec 2, 2019
yxieca
pushed a commit
that referenced
this pull request
Dec 2, 2019
Fix issue #1244 Signed-off-by: Xin Wang <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
901e2efb4f5c6a1179068b43e6a837dfff19d9d9 (HEAD -> 201911, origin/201911) [fpmsyncd] Skip routes to eth0 or docker0 (sonic-net#1606) 6c6f4fbbeb24b6e16a2bffdee760ba6a95e2ceb3 configure extra inc/lib directory for build (sonic-net#1247) cccb59efa031b817c1936a74db969debbb9b2775 [201911][Cherry-pick] [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1896) 62dc36d9da988807c7a397fd90ac2859a5a07699 [ci]: Support Azure pipelines on 201911 branch (sonic-net#1806) Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #1244
Required for the 201811 branch too.
In the ansible/roles/test/tasks/interface.yml script, there are some logics to do further checking for debugging purpose in case of PortChannels or Interfaces are down.
The problem is caused by the "rescue" blocks. According to ansible documentation https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html:
"This will ‘revert’ the failed status of the task for the run and the play will continue as if it had succeeded."
The consequence is that ansible testing playbooks using this interface.yml file will not be failed as expected when PortChannels or interfaces are down because the failures have been rescued.
The fix is to raise the failures again in the rescue blocks.
Type of change
Approach
How did you do it?
Raise the failures again in the rescue blocks.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
None
Supported testbed topology if it's a new test case?
Documentation