Skip to content

skip 2 TCs for test_nexthop_flap_skip_TCs #18792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinskwang merged 3 commits into from
Jun 24, 2025
Merged

skip 2 TCs for test_nexthop_flap_skip_TCs #18792

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66f7be2
skip 2 TCs for test_nexthop_flap_skip_TCs
siva-prasad-cisco Jun 4, 2025
4388970
Update tests_mark_conditions.yaml
siva-prasad-cisco Jun 16, 2025
6e10033
Update tests_mark_conditions.yaml
siva-prasad-cisco Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,12 +1357,24 @@ hash/test_generic_hash.py::test_nexthop_flap[CRC-INNER_IP_PROTOCOL:
conditions:
- "asic_type in ['broadcom', 'mellanox']"

hash/test_generic_hash.py::test_nexthop_flap[CRC-IP_PROTOCOL-ipv4-None-None]:
skip:
reason: "With IP Protocol alone, we don't have enough entropy to distribute the packets evenly"
Copy link
Copy Markdown
Collaborator

@lolyu lolyu Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest replacing we with Cisco-8000

conditions:
- "asic_type in ['cisco-8000']"

hash/test_generic_hash.py::test_nexthop_flap[CRC_CCITT-INNER_IP_PROTOCOL:
skip:
reason: "On Mellanox platforms, due to HW limitation, it would not support CRC algorithm on INNER_IP_PROTOCOL field. For broadcom, ECMP/LAG hash not supported in broadcom SAI. "
conditions:
- "asic_type in ['broadcom', 'mellanox']"

hash/test_generic_hash.py::test_nexthop_flap[CRC_CCITT-IP_PROTOCOL-ipv4-None-None]:
skip:
reason: "With IP Protocol alone, we don't have enough entropy to distribute the packets evenly"
Copy link
Copy Markdown
Collaborator

@lolyu lolyu Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

conditions:
- "asic_type in ['cisco-8000']"

hash/test_generic_hash.py::test_nexthop_flap[CRC_CCITT-IN_PORT:
skip:
reason: "On Mellanox platforms, due to HW limitation, when ecmp and lag hash at the same time, it would not support
Expand Down
Loading