Skip to content

skip 2 TCs for test_nexthop_flap_skip_TCs#18792

Merged
kevinskwang merged 3 commits intosonic-net:masterfrom
siva-prasad-cisco:skip_test_nexthop_flap_cisco8000
Jun 24, 2025
Merged

skip 2 TCs for test_nexthop_flap_skip_TCs#18792
kevinskwang merged 3 commits intosonic-net:masterfrom
siva-prasad-cisco:skip_test_nexthop_flap_cisco8000

Conversation

@siva-prasad-cisco
Copy link
Copy Markdown
Contributor

@siva-prasad-cisco siva-prasad-cisco commented Jun 4, 2025 •
edited
Loading

Description of PR

Summary:
adding these 2 TCs in hash/test_generic_hash.py as skip in test_condition_mark.yaml
hash/test_generic_hash.py::test_nexthop_flap[CRC-IP_PROTOCOL-ipv4-None-None
hash/test_generic_hash.py::test_nexthop_flap[CRC_CCITT-IP_PROTOCOL-ipv4-None-None

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

to skip mentioned testcases in hash/test_generic_hash.py, reason being : With IP Protocol alone, we don't have enough entropy to distribute the packets evenly

How did you do it?

adding skip reasons and conditions for two TCs in test_conditional_mark.yaml file

How did you verify/test it?

via UT

Any platform specific information?

Cisco-8000

Supported testbed topology if it's a new test case?

Documentation

bpar9
bpar9 previously approved these changes Jun 4, 2025
View reviewed changes
lolyu
lolyu reviewed Jun 16, 2025
View reviewed changes
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml Outdated

hash/test_generic_hash.py::test_nexthop_flap[CRC-IP_PROTOCOL-ipv4-None-None]:
skip:
reason: "With IP Protocol alone, we don't have enough entropy to distribute the packets evenly"
Copy link
Copy Markdown
Collaborator

@lolyu lolyu Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest replacing we with Cisco-8000

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml Outdated

hash/test_generic_hash.py::test_nexthop_flap[CRC_CCITT-IP_PROTOCOL-ipv4-None-None]:
skip:
reason: "With IP Protocol alone, we don't have enough entropy to distribute the packets evenly"
Copy link
Copy Markdown
Collaborator

@lolyu lolyu Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 16, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@siva-prasad-cisco
Copy link
Copy Markdown
Contributor Author

siva-prasad-cisco commented Jun 16, 2025

Hi @lolyu, made the changes. thanks

lolyu
lolyu approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolyu
Copy link
Copy Markdown
Collaborator

lolyu commented Jun 20, 2025

@siva-prasad-cisco please hep fix the pr failure

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 20, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jun 20, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@siva-prasad-cisco
Copy link
Copy Markdown
Contributor Author

siva-prasad-cisco commented Jun 20, 2025

Hi @lolyu, made the change in order to solve alphabetical order sort issue, thanks

wsycqyz
wsycqyz approved these changes Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

@wsycqyz
Copy link
Copy Markdown
Contributor

wsycqyz commented Jun 23, 2025

Re-trigger the PR test.

kevinskwang
kevinskwang approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinskwang kevinskwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinskwang kevinskwang merged commit 692acec into sonic-net:master Jun 24, 2025
17 of 18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 24, 2025
@siva-prasad-cisco @mssonicbld
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
1692fb9 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 24, 2025
@siva-prasad-cisco @mssonicbld
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
2e67bd6 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 24, 2025

Cherry-pick PR to 202411: #19143

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Jun 24, 2025

Cherry-pick PR to 202505: #19144

This was referenced Jun 24, 2025
Open
Merged
mssonicbld pushed a commit that referenced this pull request Jun 24, 2025
@siva-prasad-cisco @mssonicbld
skip 2 TCs for test_nexthop_flap_skip_TCs (#18792)
461393b 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
@siva-prasad-cisco @nissampa
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
d96b0a4 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@siva-prasad-cisco
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
c67c154 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@siva-prasad-cisco @gshemesh2
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
bd05bfc 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@siva-prasad-cisco @AharonMalkin
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
7b6fc95 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@siva-prasad-cisco @gshemesh2
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
049e791 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@siva-prasad-cisco @venu-nexthop
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
f12fcfb 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@siva-prasad-cisco @gshemesh2
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
f60bc3e 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@siva-prasad-cisco @ytzur1
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
aa1bff7 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@siva-prasad-cisco
skip 2 TCs for test_nexthop_flap_skip_TCs (sonic-net#18792)
c478471 
* skip 2 TCs for test_nexthop_flap_skip_TCs

* Update tests_mark_conditions.yaml

* Update tests_mark_conditions.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsycqyz wsycqyz wsycqyz approved these changes

@lolyu lolyu lolyu approved these changes

@kevinskwang kevinskwang kevinskwang approved these changes

@bpar9 bpar9 bpar9 left review comments

Assignees

No one assigned

Labels

Approved for 202411 branch Approved for 202505 branch Created PR to 202411 branch Included in 202505 branch Request for 202411 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@siva-prasad-cisco @mssonicbld @lolyu @wsycqyz @bpar9 @kevinskwang