Skip to content

[action] [PR:17858] T2:pfcwd:Fix the asic_id check - It fails for asic0#18575

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/17858
May 23, 2025
Merged

[action] [PR:17858] T2:pfcwd:Fix the asic_id check - It fails for asic0#18575
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/17858

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.

How did you do it?

Changed the check condition as mentioned above.

How did you verify/test it?

Verification in progress.

Any platform specific information?

Specific to cisco-8000.

Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement
Back port request
 202012
 202205
 202305
 202311
 202405
 202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.

How did you do it?
Changed the check condition as mentioned above.

How did you verify/test it?
Verification in progress.

Any platform specific information?
Specific to cisco-8000.

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator Author

Original PR: #17858

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mssonicbld mssonicbld merged commit 0791803 into sonic-net:202505 May 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants