T2:pfcwd:Fix the asic_id check - It fails for asic0#17858
Merged
yejianquan merged 1 commit intosonic-net:masterfrom May 23, 2025
Merged
T2:pfcwd:Fix the asic_id check - It fails for asic0#17858yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
9 tasks
Contributor
Author
|
All pfcwd passed: |
Contributor
Author
rraghav-cisco
changed the title
Contributor
Author
Merged
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 23, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#324 |
Collaborator
|
Cherry-pick PR to 202505: #18575 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
May 23, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Bug fix
Testbed and Framework(new/improvement)
New Test case
Skipped for non-supported platforms
Test case improvement
Back port request
202012
202205
202305
202311
202405
202411
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.
co-authorized by: [email protected]
Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes the issue:
raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
E failed = True
E changed = True
E rc = 2
E cmd = show platform npu script -s set_pfc_time.py
E start = 2025-01-23 04:05:01.590011
E end = 2025-01-23 04:05:03.007243
E delta = 0:00:01.417232
E msg = non-zero return code
E invocation = {'module_args': {'_raw_params': 'show platform npu script -s set_pfc_time.py', '_uses_shell': True, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E _ansible_no_log = None
E stdout =
E stderr =
E Usage: show platform npu script [OPTIONS]
E Try "show platform npu script -h" for help.
E
E Error: Missing option "-n". Choose from:
E asic0,
E asic1,
E asic2.
Type of change
Back port request
Approach
What is the motivation for this PR?
Pls see the description. "if asic_id" doesn't work if asic_id = 0. It has to be 'if asic_id == ""'.
How did you do it?
Changed the check condition as mentioned above.
How did you verify/test it?
Verification in progress.
Any platform specific information?
Specific to cisco-8000.