Skip to content

support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai#18444

Merged
StormLiangMS merged 5 commits into
sonic-net:masterfrom
sdszhang:acl_d56u2
May 19, 2025
Merged

support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai#18444
StormLiangMS merged 5 commits into
sonic-net:masterfrom
sdszhang:acl_d56u2

Conversation

@sdszhang

@sdszhang sdszhang commented May 16, 2025

Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?

Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?

Ran on physical testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang changed the title support t1-isolated-d56u2 in test_acl.py support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai May 16, 2025
Comment thread tests/acl/test_acl.py Outdated
Comment thread tests/acl/test_acl.py Outdated
Comment thread tests/qos/qos_sai_base.py Outdated
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread tests/acl/test_stress_acl.py
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@StormLiangMS StormLiangMS left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#305


dst_ip_addr = None
if tbinfo["topo"]['name'] == "t1-isolated-d28u1":
if tbinfo["topo"]['name'] in ["t1-isolated-d28u1", "t1-isolated-d56u2", "t1-isolated-d448u16"]:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanmo96 for viz. we need to fix this for v6.

sdszhang added a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 30, 2025
…_qos_sai (sonic-net#18444)

What is the motivation for this PR?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?
Ran on physical testbed.

(cherry picked from commit 33b6673)
yejianquan pushed a commit that referenced this pull request Jul 1, 2025
…changes (#19254)

* update t1-isolated-d56u2 topo with port-channel (#18152)

Description of PR
Summary:
update t1-isolated-d56u2 to use port-channel for upstream neighbor.

(cherry picked from commit b288741)

* revert topo change in #18152 and add t1-isolated-lag topo (#18683)

What is the motivation for this PR?
use new name for t1-isolated topo with upstream port-channel.

(cherry picked from commit af6a539)

* support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai (#18444)

What is the motivation for this PR?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?
Ran on physical testbed.

(cherry picked from commit 33b6673)

* Add t1-isolated-d56u1-lag into support list. (#18826)

What is the motivation for this PR?
Add t1-isolated-d56u1-lag into support list

How did you do it?
How did you verify/test it?
Run on physical testbed.

(cherry picked from commit 460e375)

* copy generate_topo.py over.
@mssonicbld

Copy link
Copy Markdown
Collaborator

@sdszhang PR conflicts with 202505 branch

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…_qos_sai (sonic-net#18444)

What is the motivation for this PR?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?
Ran on physical testbed.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…_qos_sai (sonic-net#18444)

What is the motivation for this PR?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?
Ran on physical testbed.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…_qos_sai (sonic-net#18444)

What is the motivation for this PR?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you do it?
Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai

How did you verify/test it?
Ran on physical testbed.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants