update t1-isolated-d56u2 topo with port-channel#18152
Merged
StormLiangMS merged 5 commits intosonic-net:masterfrom May 26, 2025
Merged
update t1-isolated-d56u2 topo with port-channel#18152StormLiangMS merged 5 commits intosonic-net:masterfrom
StormLiangMS merged 5 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@r12f can you help to review? |
r12f
reviewed
Apr 29, 2025
r12f
reviewed
Apr 29, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
May 3, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
failed pipeline is optional. and the failure is on radv, which is not related to this change. all other PR pipeline are passed. |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#328 |
Collaborator
|
@sdszhang PR conflicts with 202505 branch |
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
May 28, 2025
)" This reverts commit b288741.
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
May 28, 2025
11 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
May 29, 2025
What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel.
Janetxxx
pushed a commit
to Janetxxx/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Janetxxx
pushed a commit
to Janetxxx/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
…solated-lag topo (sonic-net#338) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: As discussed, revert topo change in sonic-net#18152 and use a different topo name for t1-isolated-lag topo which has upstream port-channel. cherry-pick sonic-net#18683 into 202412 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor.
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel.
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. (cherry picked from commit b288741)
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. (cherry picked from commit af6a539)
11 tasks
Xichen96
pushed a commit
to Xichen96/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
…and add t1-isolated-lag topo (sonic-net#18683) revert topo change in sonic-net#18152 and add t1-isolated-lag topo (sonic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. (cherry picked from commit af6a539)
yejianquan
pushed a commit
that referenced
this pull request
Jul 1, 2025
…changes (#19254) * update t1-isolated-d56u2 topo with port-channel (#18152) Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. (cherry picked from commit b288741) * revert topo change in #18152 and add t1-isolated-lag topo (#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. (cherry picked from commit af6a539) * support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai (#18444) What is the motivation for this PR? Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai How did you do it? Add t1-isolated-d56u2 topo support into test_acl.py, test_stress_acl.py and test_qos_sai How did you verify/test it? Ran on physical testbed. (cherry picked from commit 33b6673) * Add t1-isolated-d56u1-lag into support list. (#18826) What is the motivation for this PR? Add t1-isolated-d56u1-lag into support list How did you do it? How did you verify/test it? Run on physical testbed. (cherry picked from commit 460e375) * copy generate_topo.py over.
yejianquan
added
Included in 202505 branch
and removed
Cherry Pick Conflict_202505
labels
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Summary: update t1-isolated-d56u2 to use port-channel for upstream neighbor. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…onic-net#18683) What is the motivation for this PR? use new name for t1-isolated topo with upstream port-channel. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
update t1-isolated-d56u2 to use port-channel for upstream neighbor.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix topo uplink type
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation