Skip to content

VPP platform test_acl.py changes#18313

Merged
yejianquan merged 2 commits intosonic-net:masterfrom
AkeelAli:sonic_vpp_acl
Feb 19, 2026
Merged

VPP platform test_acl.py changes#18313
yejianquan merged 2 commits intosonic-net:masterfrom
AkeelAli:sonic_vpp_acl

Conversation

@AkeelAli
Copy link
Contributor

@AkeelAli AkeelAli commented May 9, 2025

Description of PR

Summary:

  • Adapts test_acl.py for testing on Sonic-VPP

Prerequisite PRs:

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Enabling ACL testing on VPP platform

How did you do it?

  • Enabling acl/test_acl.py for Sonic-VPP
  • Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
  • Increased the route convergence delay for VPP

How did you verify/test it?

Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%

Any platform specific information?

VPP

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@AkeelAli AkeelAli marked this pull request as draft May 9, 2025 14:37
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yue-fred-gao
Copy link
Contributor

We can close this one. Some of the change is not needed. We will create a new PR.

@mssonicbld
Copy link
Collaborator

/azp run

@AkeelAli AkeelAli reopened this Feb 12, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 12, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@mssonicbld
Copy link
Collaborator

/azp run

1 similar comment
@mssonicbld
Copy link
Collaborator

/azp run

@github-actions github-actions bot requested a review from wangxin February 12, 2026 19:19
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AkeelAli AkeelAli marked this pull request as ready for review February 17, 2026 14:59
@yue-fred-gao
Copy link
Contributor

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 89e492c into sonic-net:master Feb 19, 2026
22 checks passed
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
Description of PR
Summary:

Adapts test_acl.py for testing on Sonic-VPP
Prerequisite PRs:

Add support for sonic-vpp DUT. sonic-net#17892
Adding skip markers for Sonic VPP sonic-net#17855
Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599
vpp: support binding multiple ACL tables by priority sonic-sairedis#1732
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement

Approach
What is the motivation for this PR?
Enabling ACL testing on VPP platform

How did you do it?
Enabling acl/test_acl.py for Sonic-VPP
Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
Increased the route convergence delay for VPP
How did you verify/test it?
Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%
Any platform specific information?
VPP

signed-off-by: [email protected]
Signed-off-by: Zhuohui Tan <[email protected]>
@zjswhhh zjswhhh added the Request for 202511 branch Request to backport a change to 202511 branch label Mar 3, 2026
aronovic pushed a commit to aronovic/sonic-mgmt that referenced this pull request Mar 3, 2026
Description of PR
Summary:

Adapts test_acl.py for testing on Sonic-VPP
Prerequisite PRs:

Add support for sonic-vpp DUT. sonic-net#17892
Adding skip markers for Sonic VPP sonic-net#17855
Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599
vpp: support binding multiple ACL tables by priority sonic-sairedis#1732
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement

Approach
What is the motivation for this PR?
Enabling ACL testing on VPP platform

How did you do it?
Enabling acl/test_acl.py for Sonic-VPP
Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
Increased the route convergence delay for VPP
How did you verify/test it?
Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%
Any platform specific information?
VPP

signed-off-by: [email protected]
Signed-off-by: Mihut Aronovici <[email protected]>
ravaliyel pushed a commit to ravaliyel/sonic-mgmt that referenced this pull request Mar 12, 2026
Description of PR
Summary:

Adapts test_acl.py for testing on Sonic-VPP
Prerequisite PRs:

Add support for sonic-vpp DUT. sonic-net#17892
Adding skip markers for Sonic VPP sonic-net#17855
Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599
vpp: support binding multiple ACL tables by priority sonic-sairedis#1732
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement

Approach
What is the motivation for this PR?
Enabling ACL testing on VPP platform

How did you do it?
Enabling acl/test_acl.py for Sonic-VPP
Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
Increased the route convergence delay for VPP
How did you verify/test it?
Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%
Any platform specific information?
VPP

signed-off-by: [email protected]
Signed-off-by: Ravali Yeluri (WIPRO LIMITED) <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
Description of PR
Summary:

Adapts test_acl.py for testing on Sonic-VPP
Prerequisite PRs:

Add support for sonic-vpp DUT. sonic-net#17892
Adding skip markers for Sonic VPP sonic-net#17855
Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599
vpp: support binding multiple ACL tables by priority sonic-sairedis#1732
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement

Approach
What is the motivation for this PR?
Enabling ACL testing on VPP platform

How did you do it?
Enabling acl/test_acl.py for Sonic-VPP
Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
Increased the route convergence delay for VPP
How did you verify/test it?
Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%
Any platform specific information?
VPP

signed-off-by: [email protected]
Signed-off-by: Abhishek <[email protected]>
vrajeshe pushed a commit to vrajeshe/sonic-mgmt that referenced this pull request Mar 23, 2026
Description of PR
Summary:

Adapts test_acl.py for testing on Sonic-VPP
Prerequisite PRs:

Add support for sonic-vpp DUT. sonic-net#17892
Adding skip markers for Sonic VPP sonic-net#17855
Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599
vpp: support binding multiple ACL tables by priority sonic-sairedis#1732
Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 New Test case
 Skipped for non-supported platforms
 Test case improvement

Approach
What is the motivation for this PR?
Enabling ACL testing on VPP platform

How did you do it?
Enabling acl/test_acl.py for Sonic-VPP
Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution.
Increased the route convergence delay for VPP
How did you verify/test it?
Ran and passed the ACL test cases on Sonic-VPP

Grand summary of acl:
Total: 1000
Skip: 232
Fail Skip: 0
Pass: 768
Error: 0
Fail: 0
Negative pass count: 0
(1000/232/0/768/0/0)
Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0
Pass rate (Pass/(Total-Skip)): 768/768=100.00%
Any platform specific information?
VPP

signed-off-by: [email protected]
Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request for 202511 branch Request to backport a change to 202511 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants