Add support for sonic-vpp DUT.#17892
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| hwsku: "{{ hostvars[dut_name].hwsku }}" | ||
| num_asic: "{{ hostvars[dut_name]['num_asics'] | default(1) }}" | ||
| card_type: "{{ hostvars[dut_name]['card_type'] | default('pizzabox') }}" | ||
| asic_type: "{{ hostvars[dut_name].asic_type | default('') }}" |
There was a problem hiding this comment.
The default vpp image file name should be like "sonic-vpp.img".
Still using "sonic-vs.img" here is confusing. It means that before deploy a VPP image KVM testbed, we need to get the VPP image with name like "sonic-vpp.img", then put it under "{{ sonic_vm_storage_location }}/images/" and rename it to "sonic-vs.img". This does not really make sense.
There was a problem hiding this comment.
Updated - will use 'sonic-vpp.img' when asic_type is vpp.
| auto_recover: 'False' | ||
| comment: Tests virtual vpp switch vm | ||
|
|
||
| - conf-name: vms-kvm-vpp-t1 |
There was a problem hiding this comment.
Since there is already a vms-kvm-vpp-t1-lag, is it better to replace vms-kvm-vpp-t1 with t0 topo like vms-kvm-vpp-t0?
There was a problem hiding this comment.
Support is currently only for T1 and T1-lag, will add support for T0 in the future.
There was a problem hiding this comment.
Ok, if the preparation is ready, we can add optional PR checks on these topologys. I will provide Elastictest support and guide that you can follow to setup new pr checks.
There was a problem hiding this comment.
Ok, if the preparation is ready, we can add optional PR checks on these topologys. I will provide test infra support and the guide that you can follow to setup new pr checks.
|
@dypet Harve you verified deployment and tests for new vms-kvm-vpp tbs? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@lerry-lee Yes, tested on local setup in conjunction with the changes in this PR: #17855 . Testbed set up following instructions here: https://github.com/sonic-net/sonic-mgmt/blob/9b05ead4e8f8e35bf72cda3f948497945fd7eaf1/docs/testbed/README.testbed.VsSetup.md |
|
@wangxin please review |
…mage support (#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: #17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com
What is the motivation for this PR? Support for sonic-vpp is being added to sonic-mgmt as an alternative virtual platform. How did you do it? Updated testbed files with new DUT. How did you verify/test it? Ran sonic management using a sonic-vpp image and the vms-kvm-vpp-t1-lag, vms-kvm-vpp-t1 topology names. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
What is the motivation for this PR? Support for sonic-vpp is being added to sonic-mgmt as an alternative virtual platform. How did you do it? Updated testbed files with new DUT. How did you verify/test it? Ran sonic management using a sonic-vpp image and the vms-kvm-vpp-t1-lag, vms-kvm-vpp-t1 topology names. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
What is the motivation for this PR? Support for sonic-vpp is being added to sonic-mgmt as an alternative virtual platform. How did you do it? Updated testbed files with new DUT. How did you verify/test it? Ran sonic management using a sonic-vpp image and the vms-kvm-vpp-t1-lag, vms-kvm-vpp-t1 topology names. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com
What is the motivation for this PR? Support for sonic-vpp is being added to sonic-mgmt as an alternative virtual platform. How did you do it? Updated testbed files with new DUT. How did you verify/test it? Ran sonic management using a sonic-vpp image and the vms-kvm-vpp-t1-lag, vms-kvm-vpp-t1 topology names. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
…mage support (sonic-net#18297) Description of PR [CI] Support getbuild from specific pipeline and download vpp image. SONiC VPP DUT was supported by this PR: sonic-net#17892 VPP tops will be supported by this PR: https://github.com/sonic-net/sonic-mgmt/pull/19496/files VPP image build pipeline: https://dev.azure.com/mssonic/build/_build?definitionId=2818&_a=summary Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? To support run sonic-vpp test. How did you do it? Support download vpp image from given build pipeline. Add t1 topo mark for t1 vpp topos How did you verify/test it? Run test on Elastictest. signed-off-by: jianquanye@microsoft.com Signed-off-by: Yael Tzur <ytzur@nvidia.com>
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. #17892 Adding skip markers for Sonic VPP #17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. sonic-net#17892 Adding skip markers for Sonic VPP sonic-net#17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. sonic-net#17892 Adding skip markers for Sonic VPP sonic-net#17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. sonic-net#17892 Adding skip markers for Sonic VPP sonic-net#17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com Signed-off-by: Ravali Yeluri (WIPRO LIMITED) <v-ryeluri@microsoft.com>
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. sonic-net#17892 Adding skip markers for Sonic VPP sonic-net#17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com Signed-off-by: Abhishek <abhishek@nexthop.ai>
Description of PR Summary: Adapts test_acl.py for testing on Sonic-VPP Prerequisite PRs: Add support for sonic-vpp DUT. sonic-net#17892 Adding skip markers for Sonic VPP sonic-net#17855 Support for sonic-mgmt ACL testing on VPP sonic-sairedis#1599 vpp: support binding multiple ACL tables by priority sonic-sairedis#1732 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Enabling ACL testing on VPP platform How did you do it? Enabling acl/test_acl.py for Sonic-VPP Add check_intf_up_ports after config reload (to ensure VPP Interfaces are up before starting next iteration of tests). This check will be useful for other platforms too, ensuring interfaces are up before ACL tests continue their execution. Increased the route convergence delay for VPP How did you verify/test it? Ran and passed the ACL test cases on Sonic-VPP Grand summary of acl: Total: 1000 Skip: 232 Fail Skip: 0 Pass: 768 Error: 0 Fail: 0 Negative pass count: 0 (1000/232/0/768/0/0) Aggregate (Total/Skip/Fail-Skip/Pass/Error/Fail): 1000/232/0/768/0/0 Pass rate (Pass/(Total-Skip)): 768/768=100.00% Any platform specific information? VPP signed-off-by: jianquanye@microsoft.com Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
Description of PR
Summary:
Fixes # (issue)
This change is to add support for sonic-vpp as a DUT in sonic-mgmt.
Type of change
Back port request
Approach
What is the motivation for this PR?
Support for sonic-vpp is being added to sonic-mgmt as an alternative virtual platform.
How did you do it?
Updated testbed files with new DUT.
How did you verify/test it?
Ran sonic management using a sonic-vpp image and the vms-kvm-vpp-t1-lag, vms-kvm-vpp-t1 topology names.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation