Fix Skip tests if no portchannels are found in prepare_test_port fixture#18292
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom May 9, 2025
yanmo96:yanmo/vxlanTestFix
Merged
Fix Skip tests if no portchannels are found in prepare_test_port fixture#18292bingwang-ms merged 1 commit intosonic-net:masterfrom yanmo96:yanmo/vxlanTestFix
bingwang-ms merged 1 commit intosonic-net:masterfrom
yanmo96:yanmo/vxlanTestFix
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
approved these changes
May 9, 2025
Janetxxx
approved these changes
May 9, 2025
Contributor
Janetxxx
left a comment
Janetxxx
left a comment
There was a problem hiding this comment.
Skip when no port channels are found looks good to me.
Collaborator
|
@r12f For 202412 cherry-pcik |
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#280 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ure (sonic-net#18292) Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ure (sonic-net#18292) Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ure (sonic-net#18292) Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ure (sonic-net#18292) Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #18291
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix bug, and let code run by design.
How did you do it?
Adjust the check condition for if there is portchannel.
How did you verify/test it?
Verified by running local test on testbed with no portchannel, and was erroring out before the fix.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation