[action] [PR:18292] Fix Skip tests if no portchannels are found in prepare_test_port fixture#280
Merged
mssonicbld merged 1 commit intoAzure:202412from May 15, 2025
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes #18291 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Fix bug, and let code run by design. #### How did you do it? Adjust the check condition for if there is portchannel. #### How did you verify/test it? Verified by running local test on testbed with no portchannel, and was erroring out before the fix.  #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#18292 |
Collaborator
Author
|
/azp run |
Merged
11 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
added a commit
that referenced
this pull request
May 16, 2025
``` 81505c8 (az_upstream/202412) Merge branch '202411' of https://github.com/sonic-net/sonic-mgmt into 202412 30b7d73 (pub_upstream/202411) [202411 ] Updating the BGP, Reboot and LACP convergence cases to latest Snappi Api Model instead of Snappi_convergence module [ PR 18044 ] (#18391) e146100 [action] [PR:18292] Fix Skip tests if no portchannels are found in prepare_test_port fixture (#280) d8b9193 [action] [PR:17985] [tests_mark_conditions.yaml]: Skip GNMI/ZMQ test for isolated topology (#281) ef951e6 [action] [PR:17943] Add default routes to t1-isolated-d128 (#282) 2d3aec5 [action] [PR:18341] [route/test_route_perf] Support reading l3_alpm_template from config.bcm for TH5 platforms (#284) 6390c7d [202412][PR: 18350] disable default pfcwd for all lossy DUT (#271) b621644 [Cherry-pick] modifying Ignore message for 'Failed to get port by bridge port ID' (#263) bc9a2d2 modifying Ignore message for 'Failed to get port by bridge port ID' ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #18291
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix bug, and let code run by design.
How did you do it?
Adjust the check condition for if there is portchannel.
How did you verify/test it?
Verified by running local test on testbed with no portchannel, and was erroring out before the fix.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation