added a retry of sending traffic in ptf test_fib in case packet wasn't correctly sent to the DUT#18012
Merged
roy-sror merged 1 commit intosonic-net:masterfrom Aug 11, 2025
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-mgmt |
|
Commenter does not have sufficient privileges for PR 18012 in repo sonic-net/sonic-mgmt |
nhe-NV
approved these changes
Apr 30, 2025
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roy-sror
requested changes
Jul 14, 2025
| rcvd_port_index, rcvd_pkt = verify_packet_any_port( | ||
| self, masked_exp_pkt, dst_ports, timeout=1) | ||
| except AssertionError: | ||
| logging.error("Traffic wasn't sent successfully, trying again") |
Contributor
There was a problem hiding this comment.
need to ensure that we retry only if the packet was dropped on the server side, and not on the DUT end. otherwise, we might escape a real issue.
Contributor
Author
There was a problem hiding this comment.
This change will be delayed due to the test has an issue introduced on our side recently.
r12f
approved these changes
Jul 15, 2025
…t correctly sent to the DUT
illia-kotvitskyi
force-pushed
the
fib_test_retry_sending_traffic
branch
from
2462289 to
0a07200
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
hi @roy-sror , do you mind to help check it again? |
Contributor
bingwang-ms
approved these changes
Aug 6, 2025
Contributor
|
Hi @roy-sror please approve this PR as we discussed in the meeting that Bing is OK with the current fix. |
lolyu
approved these changes
Aug 11, 2025
roy-sror
approved these changes
Aug 11, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#641 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 12, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139
Collaborator
|
Cherry-pick PR to 202505: #20204 |
11 tasks
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139 Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…t correctly sent to the DUT (sonic-net#18012) In case of a weak nic, when a packet is not received, resend the packet Related PR: sonic-net#14139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In case of a weak nic, when a packet is not received, resend the packet
Related PR: #14139
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Avoid failing the test in case of a packet wasn't received because of a weak NIC
How did you do it?
Add a retry sending traffic in case a packet wasn't received
How did you verify/test it?
Ran test in a loop to ensure its stability
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation