Skip to content

Enhance generic hash packet sending function#14139

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:enhance_generic_hash_master
Oct 29, 2024
Merged

Enhance generic hash packet sending function#14139
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:enhance_generic_hash_master

Conversation

@echuawu
Copy link
Copy Markdown
Contributor

@echuawu echuawu commented Aug 15, 2024 •
edited
Loading

Description of PR

Enhance generic hash script packet sending function
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Some weak nic would failed to send packet incidentally

How did you do it?

Send more packets

How did you verify/test it?

Run it in internal regression

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

wsycqyz
wsycqyz approved these changes Aug 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

@wsycqyz
Copy link
Copy Markdown
Contributor

wsycqyz commented Aug 16, 2024

Do other branch need this PR?
Also please re-trigger the PR test.

@echuawu echuawu force-pushed the enhance_generic_hash_master branch from 2b76012 to 8218733 Compare August 16, 2024 02:22
@echuawu
Copy link
Copy Markdown
Contributor Author

echuawu commented Aug 16, 2024

Do other branch need this PR? Also please re-trigger the PR test.

Re-triggered. The test had been supported since 202311.

@echuawu echuawu force-pushed the enhance_generic_hash_master branch from 8218733 to 3307ff2 Compare August 21, 2024 08:52
@echuawu
Enhance generic hash script packet sending function
8feda37 
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Change-Id: I89bfa1e4de43e281d82d736b102dc33a55a8e089
@echuawu echuawu force-pushed the enhance_generic_hash_master branch from 3307ff2 to 8feda37 Compare August 28, 2024 04:29
@echuawu
Copy link
Copy Markdown
Contributor Author

echuawu commented Sep 2, 2024

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 2, 2024

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 2, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Copy Markdown
Contributor Author

echuawu commented Sep 3, 2024

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 3, 2024

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 3, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 9ba7820 into sonic-net:master Oct 29, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 29, 2024
@echuawu @mssonicbld
Enhance generic hash script packet sending function (sonic-net#14139)
efa6864 
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Change-Id: I89bfa1e4de43e281d82d736b102dc33a55a8e089
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 29, 2024

Cherry-pick PR to 202405: #15242

@mssonicbld mssonicbld mentioned this pull request Oct 29, 2024
Merged
8 tasks
mssonicbld pushed a commit that referenced this pull request Oct 29, 2024
@echuawu @mssonicbld
Enhance generic hash script packet sending function (#14139)
d73955f 
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Change-Id: I89bfa1e4de43e281d82d736b102dc33a55a8e089
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
@echuawu @sreejithsreekumaran
Enhance generic hash script packet sending function (sonic-net#14139)
cb7f454 
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Change-Id: I89bfa1e4de43e281d82d736b102dc33a55a8e089
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
@echuawu @yutongzhang-microsoft
Enhance generic hash script packet sending function (sonic-net#14139)
672a0bb 
1. In case of a weak nic, when packet is not received, resend the packet
2. Loop more times to make hash result more stable

Change-Id: I89bfa1e4de43e281d82d736b102dc33a55a8e089
@illia-kotvitskyi illia-kotvitskyi mentioned this pull request Apr 16, 2025
Merged
11 tasks
roy-sror pushed a commit that referenced this pull request Aug 11, 2025
@illia-kotvitskyi
added a retry of sending traffic in ptf test_fib in case packet wasn'…
2d46551 
…t correctly sent to the DUT (#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: #14139
mssonicbld added a commit to mssonicbld/sonic-mgmt.msft that referenced this pull request Aug 11, 2025
@mssonicbld
added a retry of sending traffic in ptf test_fib in case packet wasn'…
0c1b52d 
…t correctly sent to the DUT

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net/sonic-mgmt#14139

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Avoid failing the test in case of a packet wasn't received because of a weak NIC

#### How did you do it?
Add a retry sending traffic in case a packet wasn't received

#### How did you verify/test it?
Ran test in a loop to ensure its stability

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
@mssonicbld mssonicbld mentioned this pull request Aug 11, 2025
Merged
11 tasks
mssonicbld added a commit to Azure/sonic-mgmt.msft that referenced this pull request Aug 11, 2025
@mssonicbld
[action] [PR:18012] added a retry of sending traffic in ptf test_fib …
0e55719 
…in case packet wasn't correctly sent to the DUT (#641)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net/sonic-mgmt#14139

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Avoid failing the test in case of a packet wasn't received because of a weak NIC

#### How did you do it?
Add a retry sending traffic in case a packet wasn't received

#### How did you verify/test it?
Ran test in a loop to ensure its stability

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 12, 2025
@illia-kotvitskyi @mssonicbld
added a retry of sending traffic in ptf test_fib in case packet wasn'…
ea447d9 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139
@mssonicbld mssonicbld mentioned this pull request Aug 12, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Aug 12, 2025
@illia-kotvitskyi @mssonicbld
added a retry of sending traffic in ptf test_fib in case packet wasn'…
17ab5c3 
…t correctly sent to the DUT (#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: #14139
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
@illia-kotvitskyi @ashutosh-agrawal
added a retry of sending traffic in ptf test_fib in case packet wasn'…
8da59f0 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@illia-kotvitskyi @vidyac86
added a retry of sending traffic in ptf test_fib in case packet wasn'…
cc0920f 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@illia-kotvitskyi
added a retry of sending traffic in ptf test_fib in case packet wasn'…
838b183 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@illia-kotvitskyi @gshemesh2
added a retry of sending traffic in ptf test_fib in case packet wasn'…
3f5827f 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@illia-kotvitskyi @AharonMalkin
added a retry of sending traffic in ptf test_fib in case packet wasn'…
d07ec5a 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@illia-kotvitskyi @gshemesh2
added a retry of sending traffic in ptf test_fib in case packet wasn'…
8304915 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@illia-kotvitskyi @venu-nexthop
added a retry of sending traffic in ptf test_fib in case packet wasn'…
6151945 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@illia-kotvitskyi @gshemesh2
added a retry of sending traffic in ptf test_fib in case packet wasn'…
4df41fb 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@illia-kotvitskyi @ytzur1
added a retry of sending traffic in ptf test_fib in case packet wasn'…
1623ee0 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@illia-kotvitskyi
added a retry of sending traffic in ptf test_fib in case packet wasn'…
a1f36c1 
…t correctly sent to the DUT (sonic-net#18012)

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsycqyz wsycqyz wsycqyz approved these changes

@bingwang-ms bingwang-ms bingwang-ms approved these changes

Assignees

No one assigned

Labels

Approved for 202405 branch Included in 202405 branch Request for 202311 branch Request for 202405 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@echuawu @wsycqyz @mssonicbld @bingwang-ms @nhe-NV