Skip to content

[202405] Fixed two issues causing test failures in test_vxlan_bfd_tsa.py#17666

Merged
bingwang-ms merged 1 commit intosonic-net:202405from
mramezani95:mramezani/test_vxlan_bfd_tsa_202405
Mar 24, 2025
Merged

[202405] Fixed two issues causing test failures in test_vxlan_bfd_tsa.py#17666
bingwang-ms merged 1 commit intosonic-net:202405from
mramezani95:mramezani/test_vxlan_bfd_tsa_202405

Conversation

@mramezani95
Copy link
Contributor

@mramezani95 mramezani95 commented Mar 24, 2025

Description of PR

This PR fixes test failures in test_vxlan_bfd_tsa.py::Test_VxLAN_BFD_TSA. These failures were observed on some platforms such as Mellanox msn4600c and Cisco 8102.

Summary:
Fixes #15728
Microsoft ADO ID: 31220198
PR for the master branch: #17511
The following two fixed were applied for test_tsa_case4, test_tsa_case5, and test_tsa_case6:

  1. Replaced the manual execution of sudo config reload -y with a call to config_reload so that all interfaces and ports are up before configuring a VXLAN on the switch.
  2. Added a check after configuring VNET routes to ensure that VNET routes are applied to the ASIC DB before running PTF tests.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

test_tsa_case4, test_tsa_case5, and test_tsa_case6 failed on some platforms such as Mellanox msn4600c and Cisco 8102.

How did you do it?

By using config_reload instead of executing sudo config reload -y directly and making sure that VNET routes are applied to the ASIC DB before running PTF tests.

How did you verify/test it?

Ran the tests on a Mellanox msn4600c switch.
Note: In order for the tests to pass, the image running on the switch must have the following fix from sonic-utilities:
revert YANG check in db_migrator

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <[email protected]>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <[email protected]>

---------

Signed-off-by: Mahdi Ramezani <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bingwang-ms bingwang-ms merged commit e208d4d into sonic-net:202405 Mar 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants