Skip to content

Fixed two issues causing test failures in test_vxlan_bfd_tsa.py#17511

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
mramezani95:mramezani/test_vxlan_bfd_tsa
Mar 14, 2025
Merged

Fixed two issues causing test failures in test_vxlan_bfd_tsa.py#17511
bingwang-ms merged 2 commits intosonic-net:masterfrom
mramezani95:mramezani/test_vxlan_bfd_tsa

Conversation

@mramezani95
Copy link
Contributor

@mramezani95 mramezani95 commented Mar 13, 2025

Description of PR

This PR fixes test failures in test_vxlan_bfd_tsa.py::Test_VxLAN_BFD_TSA. These failures were observed on some platforms such as Mellanox msn4600c and Cisco 8102.

Summary:
Fixes #15728
Microsoft ADO ID: 31220198
The following two fixed were applied for test_tsa_case4, test_tsa_case5, and test_tsa_case6:

  1. Replaced the manual execution of sudo config reload -y with a call to config_reload so that all interfaces and ports are up before configuring a VXLAN on the switch.
  2. Added a check after configuring VNET routes to ensure that VNET routes are applied to the ASIC DB before running PTF tests.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

test_tsa_case4, test_tsa_case5, and test_tsa_case6 failed on some platforms such as Mellanox msn4600c and Cisco 8102.

How did you do it?

By using config_reload instead of executing sudo config reload -y directly and making sure that VNET routes are applied to the ASIC DB before running PTF tests.

How did you verify/test it?

Ran the tests on a Mellanox msn4600c switch.
Note: In order for the tests to pass, the image running on the switch must have the following fix from sonic-utilities:
revert YANG check in db_migrator

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn
kperumalbfn previously approved these changes Mar 13, 2025
Copy link
Collaborator

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please enable these tests in master after merge - #15978

prsunny
prsunny previously approved these changes Mar 13, 2025
@prsunny
Copy link
Contributor

prsunny commented Mar 13, 2025

@bingwang-ms , FYI. This should be fixing the Vxlan issues. Please merge

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
@mramezani95 mramezani95 dismissed stale reviews from prsunny and kperumalbfn via 70efd66 March 13, 2025 23:28
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit 1d701f7 into sonic-net:master Mar 14, 2025
13 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 14, 2025
…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

---------

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #17529

kperumalbfn pushed a commit that referenced this pull request Mar 14, 2025
…7511) (#17529)

Fixed two issues causing test failures in `test_vxlan_bfd_tsa.py
mramezani95 added a commit to mramezani95/sonic-mgmt that referenced this pull request Mar 24, 2025
…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

---------

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
bingwang-ms pushed a commit that referenced this pull request Mar 24, 2025
…7511) (#17666)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

---------

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

---------

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…nic-net#17511)

* Fixed two issues causing test failures in 'test_vxlan_bfd_tsa.py'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

* Added 'wait_for_bgp=True'

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>

---------

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Test case4/case5/case6 in tests/vxlan/test_vxlan_bfd_tsa.py is unstable.

5 participants