Bring back vs chassis support#17647
Merged
wangxin merged 5 commits intosonic-net:masterfrom Mar 26, 2025
Merged
Conversation
…nic-net#16716)" (sonic-net#17501)" This reverts commit 0a9ff07.
…onic-net#17516)" (sonic-net#17616)" This reverts commit 727dcdf.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Mar 26, 2025
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf.
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf.
Contributor
There was a problem hiding this comment.
Copilot reviewed 16 out of 23 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- ansible/lab: Language not supported
- ansible/roles/vm_set/templates/sonic.xml.j2: Language not supported
- ansible/setup_vs_chassis.sh: Language not supported
- ansible/templates/vs_chassis_metadata.json.j2: Language not supported
- ansible/testbed-cli.sh: Language not supported
- ansible/vars/topo_t2-vs.yml: Language not supported
- ansible/veos_vtb: Language not supported
Comments suppressed due to low confidence (1)
ansible/library/port_alias.py:402
- [nitpick] Consider renaming the key 'front_panel_asic_ifs_asic_id' to a clearer identifier such as 'front_panel_asic_ids' for consistency and improved readability.
"front_panel_asic_ifs_asic_id': front_panel_asic_ifs_asic_id_list,
Comment on lines
+335
to
+336
| self._vs_chassis_midplane_br_name = VS_CHASSIS_MIDPLANE_BRIDGE_NAME_TEMPLATE.format(vm_set_name=vm_set_name) | ||
| self._vs_chassis_inband_br_name = VS_CHASSIS_INBAND_BRIDGE_NAME_TEMPLATE.format(vm_set_name=vm_set_name) |
There was a problem hiding this comment.
Consider handling long vm_set_name values more gracefully to avoid a ValueError when the VS chassis bridge name exceeds MAX_INTF_LEN; you might truncate or pre-validate vm_set_name before formatting the bridge names.
Suggested change
| self._vs_chassis_midplane_br_name = VS_CHASSIS_MIDPLANE_BRIDGE_NAME_TEMPLATE.format(vm_set_name=vm_set_name) | |
| self._vs_chassis_inband_br_name = VS_CHASSIS_INBAND_BRIDGE_NAME_TEMPLATE.format(vm_set_name=vm_set_name) | |
| truncated_vm_set_name = self._truncate_vm_set_name(vm_set_name) | |
| self._vs_chassis_midplane_br_name = VS_CHASSIS_MIDPLANE_BRIDGE_NAME_TEMPLATE.format(vm_set_name=truncated_vm_set_name) | |
| self._vs_chassis_inband_br_name = VS_CHASSIS_INBAND_BRIDGE_NAME_TEMPLATE.format(vm_set_name=truncated_vm_set_name) |
r12f
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Aug 7, 2025
As PR sonic-net/sonic-mgmt#17647 and sonic-net/sonic-mgmt#18790 are not included in 202412, some parameters in `vm_topology.py` are not supported. So in this PR, we removed such unsupported parameters.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf. Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf. Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Revert two revert commits that removed VS chassis support and add a fix that handled a problem in restart-ptf.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation