Skip to content

Fix the issue introduced by the PR #16716#17516

Merged
yejianquan merged 1 commit intosonic-net:masterfrom
nhe-NV:fix_pr_issue
Mar 17, 2025
Merged

Fix the issue introduced by the PR #16716#17516
yejianquan merged 1 commit intosonic-net:masterfrom
nhe-NV:fix_pr_issue

Conversation

@nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented Mar 14, 2025

Description of PR

Summary: After the #16716 merged, the remove topo failed. fix it in this PR
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Deploy the setup could pass with the fix

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@xwjiang-ms
Copy link
Contributor

Please comment with '/azpw run' to start PR checker

@nhe-NV
Copy link
Contributor Author

nhe-NV commented Mar 14, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 8d9ec3c into sonic-net:master Mar 17, 2025
18 checks passed
nhe-NV added a commit to nhe-NV/sonic-mgmt that referenced this pull request Mar 17, 2025
Description of PR
Summary: After the sonic-net#16716 merged, the remove topo failed. fix it in this PR
Fixes # (issue)

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Deploy the setup could pass with the fix

co-authorized by: jianquanye@microsoft.com
wangxin added a commit that referenced this pull request Mar 20, 2025
StormLiangMS pushed a commit that referenced this pull request Mar 20, 2025
BYGX-wcr added a commit to BYGX-wcr/sonic-mgmt that referenced this pull request Mar 21, 2025
amulyan7 pushed a commit to amulyan7/sonic-mgmt that referenced this pull request Mar 31, 2025
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
Description of PR
Summary: After the sonic-net#16716 merged, the remove topo failed. fix it in this PR
Fixes # (issue)

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Deploy the setup could pass with the fix

co-authorized by: jianquanye@microsoft.com
OriTrabelsi pushed a commit to OriTrabelsi/sonic-mgmt that referenced this pull request Apr 1, 2025
@nhe-NV nhe-NV deleted the fix_pr_issue branch July 7, 2025 08:08
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…#17516)" (sonic-net#17616)

This reverts commit 8d9ec3c.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
Description of PR
Summary: After the sonic-net#16716 merged, the remove topo failed. fix it in this PR
Fixes # (issue)

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Deploy the setup could pass with the fix

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…#17516)" (sonic-net#17616)

This reverts commit 8d9ec3c.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
Description of PR
Summary: After the sonic-net#16716 merged, the remove topo failed. fix it in this PR
Fixes # (issue)

Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Deploy the setup could pass with the fix

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…#17516)" (sonic-net#17616)

This reverts commit 8d9ec3c.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants