Skip to content

[pytest] Add Option to Control Collect Techsupport #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tahmed-dev merged 3 commits into from
Jun 18, 2020
Merged

[pytest] Add Option to Control Collect Techsupport #1755

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b1455
[pytest] Disable Collect Techsupport By Default
tahmed-dev Jun 11, 2020
9149eea
review commit: enable tech support collect by default
tahmed-dev Jun 18, 2020
2d3bf44
fix help messahe
tahmed-dev Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ def pytest_addoption(parser):
help="Change default loops delay")
parser.addoption("--logs_since", action="store", type=int,
help="number of minutes for show techsupport command")
parser.addoption("--collect_techsupport", action="store", default=True, type=bool,
help="Enable/Disable tech support collection. Default is enabled (True)")

############################
# sanity_check options #
Expand Down Expand Up @@ -358,7 +360,7 @@ def collect_techsupport(request, duthost):
# request.node is an "item" because we use the default
# "function" scope
testname = request.node.name
if request.node.rep_call.failed:
if request.config.getoption("--collect_techsupport") and request.node.rep_call.failed:
res = duthost.shell("generate_dump")
fname = res['stdout']
duthost.fetch(src=fname, dest="logs/{}".format(testname))
Expand Down