Skip to content

[pytest] Add Option to Control Collect Techsupport#1755

Merged
tahmed-dev merged 3 commits intosonic-net:masterfrom
tahmed-dev:taahme/disable-collect-techsupport
Jun 18, 2020
Merged

[pytest] Add Option to Control Collect Techsupport#1755
tahmed-dev merged 3 commits intosonic-net:masterfrom
tahmed-dev:taahme/disable-collect-techsupport

Conversation

@tahmed-dev
Copy link
Contributor

@tahmed-dev tahmed-dev commented Jun 11, 2020

Description of PR

Summary:
Adding an option to enable/disable techsupport collection from the command
line. Default is enabled.

signed-off-by: Tamer Ahmed [email protected]

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

tech support takes long time and so we need an option to disable it.

How did you do it?

Added an option to disable the collection of the techsupport

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Adding an option to disable techsupport collection from the command
line. Default is disabled.

signed-off-by: Tamer Ahmed <[email protected]>
@tahmed-dev tahmed-dev force-pushed the taahme/disable-collect-techsupport branch from 8d550fa to 9149eea Compare June 18, 2020 16:33
@tahmed-dev tahmed-dev requested a review from daall June 18, 2020 16:35
@tahmed-dev tahmed-dev marked this pull request as ready for review June 18, 2020 16:36
Copy link
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably just want to revise the PR title since the behavior has changed.

@tahmed-dev tahmed-dev changed the title [pytest] Disable Collect Techsupport By Default [pytest] Add Knob to Control Collect Techsupport Jun 18, 2020
@tahmed-dev tahmed-dev changed the title [pytest] Add Knob to Control Collect Techsupport [pytest] Add Option to Control Collect Techsupport Jun 18, 2020
@tahmed-dev tahmed-dev requested a review from neethajohn June 18, 2020 17:41
@tahmed-dev tahmed-dev merged commit ca24f81 into sonic-net:master Jun 18, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss

73f6f68 [Flex Counters] Delay flex counters even if tables are present in the DB (sonic-net#1877)
5edb9e5 [buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857)
fce0c60 [crm] Fix for Issue sonic-net/sonic-buildimage#8036 (sonic-net#1829)

sonic-utilities

2630ac1 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (sonic-net#1768)
606f1b1 [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (sonic-net#1755)
2c6a15e [ecnconfig] Fix exception seen during display and add unit tests (#1784)
9b1995e Fix logic in RIF counters print (sonic-net#1732)

sonic-swss-comon

3e7b81f Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (sonic-net#523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants