[wr_arp] Fix use of inventory file#1725
Merged
tahmed-dev merged 1 commit intosonic-net:masterfrom Jun 2, 2020
Merged
Conversation
Commit 9814959 introduced mutiple inventory files that broke the logic to retreive secrets for specific inventory. Use inventory_file defined in hostvars instead. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
neethajohn
approved these changes
Jun 2, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
97d971372fac773b98d46bb8f800df7b845e518e (HEAD -> 201911, origin/201911) [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594) (sonic-net#1729) 2099c73cea81ff4524e680b6f9335c0b0f13b94e [CLI] Implement null_route_helper script (sonic-net#1740) b56659175986fe0e5b82c6bd6b3dde163164777b [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1725) e840c42da2a40db2bf993672271f6b75c51c426f Change the method name to align with master, reduce diverge issue (sonic-net#1703) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Commit 9814959 introduced multiple inventory files that broke the
logic to retrieve secrets for specific inventory. Use inventory_file
defined in hostvars instead.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation