[Mellanox] Fixes test_sfp_presence deprecated SFP sysfs#1703
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 11, 2020
shlomibitton:shlomi_sfp_presence_fix
Merged
[Mellanox] Fixes test_sfp_presence deprecated SFP sysfs#1703wangxin merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_sfp_presence_fix
wangxin merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_sfp_presence_fix
Conversation
liat-grozovik
approved these changes
May 26, 2020
keboliu
reviewed
May 27, 2020
|
This pull request introduces 1 alert when merging 839dd72e64e4329cd083d69886f170659321ddfa into ff8cd16 - view on LGTM.com new alerts:
|
nazariig
approved these changes
Jun 11, 2020
Change-Id: Idfd75f2d4c47b9a67b0f4bc96b3c08b6fbd6fc4c Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
|
This pull request introduces 1 alert and fixes 1 when merging 77d4500 into ff8cd16 - view on LGTM.com new alerts:
fixed alerts:
|
wangxin
approved these changes
Jun 11, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Changes: ac4596a [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (sonic-net#1703) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
97d971372fac773b98d46bb8f800df7b845e518e (HEAD -> 201911, origin/201911) [sfpshow] Gracefully handle improper 'specification_compliance' field (sonic-net#1594) (sonic-net#1729) 2099c73cea81ff4524e680b6f9335c0b0f13b94e [CLI] Implement null_route_helper script (sonic-net#1740) b56659175986fe0e5b82c6bd6b3dde163164777b [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1725) e840c42da2a40db2bf993672271f6b75c51c426f Change the method name to align with master, reduce diverge issue (sonic-net#1703) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Idfd75f2d4c47b9a67b0f4bc96b3c08b6fbd6fc4c
Signed-off-by: Shlomi Bitton shlomibi@mellanox.com
Description of PR
Summary:
Fixes 'test_sfp_presence' deprecated SFP sysfs.
Type of change
Approach
How did you do it?
Edit the test to suite current sysfs structure.
How did you verify/test it?
Run the test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation