Skip to content

[reload config] use /bin/bash as shell for config reload #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 1 commit into from
Jun 1, 2020
Merged

[reload config] use /bin/bash as shell for config reload #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/config_reload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ def config_reload(duthost, config_source='config_db', wait=120):
logger.info('reloading {}'.format(config_source))

if config_source == 'minigraph':
duthost.shell('config load_minigraph -y &>/dev/null')
duthost.shell('config load_minigraph -y &>/dev/null', executable="/bin/bash")
duthost.shell('config save -y')

if config_source == 'config_db':
duthost.shell('config reload -y &>/dev/null')
duthost.shell('config reload -y &>/dev/null', executable="/bin/bash")

time.sleep(wait)
2 changes: 1 addition & 1 deletion tests/platform_tests/test_reload_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_reload_configuration(duthost, conn_graph_facts):
asic_type = duthost.facts["asic_type"]

logging.info("Reload configuration")
duthost.shell("sudo config reload -y &>/dev/null")
duthost.shell("sudo config reload -y &>/dev/null", executable="/bin/bash")

logging.info("Wait until all critical services are fully started")
check_critical_services(duthost)
Expand Down
2 changes: 1 addition & 1 deletion tests/vlan/test_vlan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def tearDown(vlan_ports_list, duthost, ptfhost, vlan_intfs_list, portchannel_int
except RunAnsibleModuleFail as e:
logger.error(e)

duthost.shell("config reload -y &>/dev/null")
duthost.shell("config reload -y &>/dev/null", executable="/bin/bash")

# make sure Portchannels go up for post-test link sanity
time.sleep(90)
Expand Down