[reload config] use /bin/bash as shell for config reload#1705
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jun 1, 2020
Merged
[reload config] use /bin/bash as shell for config reload#1705yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
This change was introduced in sonic-net#1687 to fix connection reset caused by 'config reload'. The fix was to redirect output to /dev/null. Shell will interpret 'config reload -y &> /dev/null' as request to run the command in the background instead of redirecting stdout/stderr to /dev/null. It looks like not the redirection fixed the issue but the fact that it was running in background. However, it introduced another issue because config reload takes ~1.5m so that 90/120 sec wait time is not enough time waiting for system to become ready. Change-Id: I9d44c0a55e4fa016bbe177524891c9b14302c761 Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
neethajohn
approved these changes
May 28, 2020
yxieca
approved these changes
Jun 1, 2020
shlomibitton
pushed a commit
to Junchao-Mellanox/sonic-mgmt
that referenced
this pull request
Jul 12, 2020
) This change was introduced in sonic-net#1687 to fix connection reset caused by 'config reload'. The fix was to redirect output to /dev/null. Shell will interpret 'config reload -y &> /dev/null' as request to run the command in the background instead of redirecting stdout/stderr to /dev/null. It looks like not the redirection fixed the issue but the fact that it was running in background. However, it introduced another issue because config reload takes ~1.5m so that 90/120 sec wait time is not enough time waiting for system to become ready. Change-Id: I9d44c0a55e4fa016bbe177524891c9b14302c761 Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Includes below commits ``` d19829c 2021-07-16 | Revert "[minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705)" [Guohan Lu] cd1f6e6 2021-07-15 | Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709) [Andriy Kokhan] 66c34c0 2021-07-15 | [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705) [Blueve] ```
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
1c12a4050fecabd88245c7aa64a61259bc00db3b (HEAD -> 201911, origin/201911)Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705) (sonic-net#2196) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was introduced in
#1687 to fix connection reset
caused by 'config reload'. The fix was to redirect output to /dev/null.
Shell will interpret 'config reload -y &> /dev/null' as request to run
the command in the background instead of redirecting stdout/stderr to
/dev/null. It looks like not the redirection fixed the issue but the
fact that it was running in background. However, it introduced another
issue because config reload takes ~1.5m so that 90/120 sec wait time is
not enough time waiting for system to become ready.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
I ran vlan test and verified that test waits till config reload finishes. Before this change vlan test finishes, "config reload -y" running in background gets killed and leaves system with stopped swss. With this change vlan test behaves correctly.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation