-
Notifications
You must be signed in to change notification settings - Fork 1k
Test TX drop counter on oper down #17014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BYGX-wcr
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
BYGX-wcr:test_tx_drop_counter_on_oper_down
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import logging | ||
| import pytest | ||
| import time | ||
|
|
||
| from tests.common.helpers.assertions import pytest_assert | ||
| from tests.common.portstat_utilities import parse_portstat | ||
|
|
||
| logger = logging.getLogger('__name__') | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('any') | ||
| ] | ||
|
|
||
|
|
||
| def test_tx_drop_counters_on_oper_down_intf(duthosts, enum_rand_one_per_hwsku_frontend_hostname, nbrhosts): | ||
| """ | ||
| Test that TX_DROP counters are not incremented when the interface is oper down. | ||
| """ | ||
| duthost = duthosts[enum_rand_one_per_hwsku_frontend_hostname] | ||
| interfaces = duthost.shell("show lldp table")['stdout_lines'][3:] | ||
| # find an oper up and admin up interface | ||
| if len(interfaces) == 0: | ||
| pytest.skip('No interfaces connected to switch neighbors found') | ||
| intf = interfaces[0].split()[0] | ||
| neighbor = interfaces[0].split()[1] | ||
| neighbor_intf = interfaces[0].split()[2] | ||
|
|
||
| assert neighbor, "Cannot find the hostname of neighbor connected to {}".format(intf) | ||
| assert neighbor_intf, "Cannot find the interface name of neighbor connected to {}".format(intf) | ||
|
|
||
| # get the neighbor's IP | ||
| bgp_neighbors = duthost.shell("show ip bgp summary")['stdout_lines'] | ||
| for line in bgp_neighbors: | ||
| if neighbor in line: | ||
| neighbor_ip = line.split()[0] | ||
| break | ||
| assert neighbor_ip, "Cannot find the IP address of neighbor" | ||
|
|
||
| logger.info('DUT Interface: {}, Neighbor: {}, Neighbor Interface: {}, Neighbor IP: {}' | ||
| .format(intf, neighbor, neighbor_intf, neighbor_ip)) | ||
|
|
||
| # shutdown the interface of neighbor | ||
| nbrhosts[neighbor]['host'].shutdown(neighbor_intf) | ||
| time.sleep(2) | ||
|
|
||
| # collect portstat before sleeping | ||
| before_portstat = parse_portstat(duthost.command('portstat -i {}'.format(intf))['stdout_lines']) | ||
|
|
||
| # Ping the neighbor from DUT | ||
| duthost.command('ping {} -c 10'.format(neighbor_ip), module_ignore_errors=True) | ||
|
|
||
| # collect portstat after sleeping | ||
| after_portstat = parse_portstat(duthost.command('portstat -i {}'.format(intf))['stdout_lines']) | ||
|
|
||
| # Assert that TX_DROP counters are not incremented | ||
| pytest_assert(before_portstat[intf]['tx_drp'] == after_portstat[intf]['tx_drp'], | ||
| 'TX_DROP counters should not be incremented when the interface is administratively down') | ||
|
|
||
| # recover the neighbor interface | ||
| nbrhosts[neighbor]['host'].no_shutdown(neighbor_intf) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to move to intf shut/unshut to a fixture that handles test setup and teardown, that way the intf will be brought back up even if the test fails.