Skip to content

[On hold, merge if required] chore: temporarily skip show mac sanity #16942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cyw233 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Draft

[On hold, merge if required] chore: temporarily skip show mac sanity #16942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/common/plugins/sanity_check/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ def _is_voq_chassis(duthosts):
if 'check_mac_entry_count' in filtered_check_items:
filtered_check_items.remove('check_mac_entry_count')

# Temporarily disable check_mac_entry_count sanity due to a known issue. Will be enabled after the issue is fixed.
Copy link
Collaborator

@yejianquan yejianquan Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyw233 does this check causes any issue in chassis test?

Copy link
Contributor Author

@cyw233 cyw233 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yejianquan No not yet, this sanity is being skipped on VoQ chassis (code ref), so I think we will be the first one running this in our Nightly.

Last time @abdosi quickly mentioned there will be a small chance that show mac command would get stuck, so I created this PR. Maybe we can hold this PR now and only merge it when this sanity check is actually causing any issues?

Copy link
Collaborator

@yejianquan yejianquan Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would prefer to hold this PR for now

if 'check_mac_entry_count' in filtered_check_items:
filtered_check_items.remove('check_mac_entry_count')

return filtered_check_items


Expand Down
Loading