[On hold, merge if required] chore: temporarily skip show mac sanity#16942
Draft
cyw233 wants to merge 1 commit intosonic-net:masterfrom
Draft
[On hold, merge if required] chore: temporarily skip show mac sanity#16942cyw233 wants to merge 1 commit intosonic-net:masterfrom
cyw233 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
temporarily-skip-show-mac-sanity
branch
from
db7b760 to
bd07350
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
reviewed
Feb 13, 2025
| if 'check_mac_entry_count' in filtered_check_items: | ||
| filtered_check_items.remove('check_mac_entry_count') | ||
|
|
||
| # Temporarily disable check_mac_entry_count sanity due to a known issue. Will be enabled after the issue is fixed. |
Collaborator
There was a problem hiding this comment.
@cyw233 does this check causes any issue in chassis test?
Contributor
Author
There was a problem hiding this comment.
@yejianquan No not yet, this sanity is being skipped on VoQ chassis (code ref), so I think we will be the first one running this in our Nightly.
Last time @abdosi quickly mentioned there will be a small chance that show mac command would get stuck, so I created this PR. Maybe we can hold this PR now and only merge it when this sanity check is actually causing any issues?
Collaborator
There was a problem hiding this comment.
Yeah, I would prefer to hold this PR for now
cyw233
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Temporarily skip the
check_mac_entry_countsanity check.Summary:
Fixes # (issue) Microsoft ADO 31238387
Type of change
Back port request
Approach
What is the motivation for this PR?
There's a known issue for the "sudo ip netns exec asic0 show mac" command, so we wanted to skip it until we fix the issue. Microsoft ADO 31238387 was created to track this issue
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation