[QoS] Support designating the packet size when testing water mark of shared buffer#1663
Merged
neethajohn merged 2 commits intosonic-net:masterfrom May 26, 2020
stephenxs:qos-arbitrary-packet-size-watermark-shared
Merged
[QoS] Support designating the packet size when testing water mark of shared buffer#1663neethajohn merged 2 commits intosonic-net:masterfrom stephenxs:qos-arbitrary-packet-size-watermark-shared
neethajohn merged 2 commits intosonic-net:masterfrom
stephenxs:qos-arbitrary-packet-size-watermark-shared
Conversation
Contributor
Author
|
In this PR, a new parameter of packet_size is introduced. It needs to be added for all SKUs. |
neethajohn
requested changes
May 20, 2020
ansible/roles/test/tasks/qos_sai.yml
Outdated
| - pkts_num_fill_min='{{qp.wm_pg_shared_lossless.pkts_num_fill_min}}' | ||
| - pkts_num_fill_shared='{{qp.wm_pg_shared_lossless.pkts_num_trig_pfc}}' | ||
| - cell_size='{{qp.wm_pg_shared_lossless.cell_size}}' | ||
| - packet_size='{{qp.wm_pg_shared_lossless.packet_size}}' |
Contributor
There was a problem hiding this comment.
This will currently fail since vars/qos.yml doesn't have this parameter defined.
Contributor
There was a problem hiding this comment.
Please remove the qos_sai.yml changes from this PR. you can add them in the new format once #1682 is merged
neethajohn
approved these changes
May 26, 2020
yxieca
pushed a commit
that referenced
this pull request
Jun 9, 2020
…shared buffer (#1663) * [qos] Support designating the packet size when testing water mark of shared buffer
shlomibitton
pushed a commit
to Junchao-Mellanox/sonic-mgmt
that referenced
this pull request
Jul 12, 2020
commit 0334657 Author: Xin Wang <[email protected]> Date: Wed May 27 09:28:17 2020 +0800 Fix warning "provided hosts list is empty, only localhost is available" (sonic-net#1700) Signed-off-by: Xin Wang <[email protected]> commit 2786c57 Author: Stephen Sun <[email protected]> Date: Wed May 27 02:03:40 2020 +0800 [QoS] Support designating the packet size when testing water mark of shared buffer (sonic-net#1663) * [qos] Support designating the packet size when testing water mark of shared buffer Change-Id: I9464564494f454bad2fe5aedea5305524ed179e2 Signed-off-by: Stepan Blyschak <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…7411) adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) 8a732726 [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) 7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) ed32e333 [portsorch] Configure hostif tagging for subports (sonic-net#1573) b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711) 515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706) 0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1710) Signed-off-by: Stephen Sun <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nic-net#8627) 7041400 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) (sonic-net#1786) 399d370 Fix logic in RIF counters print (sonic-net#1732) 8329544 [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) 193b028 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663) 2c82bcf [neighbor_advertiser] Use existing tunnel if present for creating tunnel mappings (sonic-net#1589) 8e22960 [202012][Config] Update config command of Kdump. (sonic-net#1778) be3e5c6 [show][config] cli refactor for muxcable with abstract class implementation from vendors (sonic-net#1722) (sonic-net#1782)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
da3bbef916cd31267640dd4dc5823d82ee637b1e (HEAD -> 201911)
[neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
0fa589372ed391dd91f733d8a92b4f604118e8f7 (origin/201911)
[201911][db_migrator][Mellanox] Update Mellanox buffer migrator with
2km-cable supported (sonic-net#1575)
Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Support designating the packet size when testing the watermark of the shared buffer.
The logic of the shared buffer watermark test is sending packets to occupy the shared buffer and then polling its watermark. Originally small packets were sent to occupy the shared buffer.
However, it's a very rare scenario that all shared buffer is occupied by small packets. To make it more generic and close to the real-world scenario, we are going to support arbitrary packet size.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation