Fix test_iface_namingmode.py::test_show_ip_route_v4 for T2 topo#7411
Merged
wenyiz2021 merged 1 commit intosonic-net:masterfrom Feb 9, 2023
Merged
Fix test_iface_namingmode.py::test_show_ip_route_v4 for T2 topo#7411wenyiz2021 merged 1 commit intosonic-net:masterfrom
wenyiz2021 merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
Add @arlakshm @wenyiz2021 for viz. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Feb 8, 2023
Contributor
|
/Azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
pushed a commit
that referenced
this pull request
Feb 13, 2023
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
iface_namingmode/test_iface_namingmode.py::test_show_ip_route_v4 checks the output of 'show ip route 192.168.1.1' and makes sure the alias/name of spine/updstream ports is correctly in the output. However, in T2 topo, 192.168.1.1 is forwarded via a route learnt over ibgp and thus the interfaces in 'show ip route' output are inband ports. Fix the issue by explicitly checking the output of default route, which is learnt over ebgp via upstream ports.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation