[SRv6] Add SRv6 control plane test case#16516
Merged
abdosi merged 7 commits intosonic-net:masterfrom Jan 21, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
reviewed
Jan 14, 2025
| duthost.command("sonic-db-cli CONFIG_DB HSET SRV6_MY_SIDS\\|loc1\\|fcbb:bbbb:1:1:: action uN") | ||
| time.sleep(WAIT_TIME) | ||
|
|
||
| frr_config = duthost.command("vtysh -c \"show running-config\"")["stdout"] |
Contributor
There was a problem hiding this comment.
let's make this test case multi-asic aware for future proof.
abdosi
reviewed
Jan 14, 2025
|
|
||
| # add Vrf1 config | ||
| duthost.command("config vrf add Vrf1") | ||
| duthost.command("sysctl -w net.vrf.strict_mode=1") |
Contributor
There was a problem hiding this comment.
for sonic testing do we need this >
Contributor
Author
There was a problem hiding this comment.
yes, without this setting. uDT46 SID will not get programmed into kernel and APPL_DB
There was a problem hiding this comment.
Yes, this is needed.
‑ By default, FRR tries to install all routes in the Linux kernel before installing in SONiC
‑ In order to have the SID programmed into SONiC APPL DB, they must be successfully programmed in the Linux Kernel first
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ahsalam
approved these changes
Jan 20, 2025
cscarpitta
approved these changes
Jan 20, 2025
|
The changes in this PR (sonic-net/sonic-buildimage#21467) are required here. |
abdosi
reviewed
Jan 21, 2025
| import pytest | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t0') |
Contributor
There was a problem hiding this comment.
also i think we need to add vs also
abdosi
previously approved these changes
Jan 21, 2025
Contributor
abdosi
left a comment
abdosi
left a comment
There was a problem hiding this comment.
Just change the marker to include t1 also
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
updated |
abdosi
approved these changes
Jan 21, 2025
This was referenced Jan 22, 2025
wangxin
pushed a commit
that referenced
this pull request
Jan 22, 2025
What is the motivation for this PR? Script srv6/test_srv6_static_config.py was added in PR #16516, and it fails to run on kvm testbed. We temporarily skip this test in PR testing using conditional mark. How did you do it? We temporarily skip this test in PR testing using conditional mark. How did you verify/test it? Test by pipeline itself to see if this script can be skipped on kvm testbed.
r12f
added
Approved for msft-202412 Branch
and removed
Approved for msft-202412 Branch
labels
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#42 |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Summary: Add a control plane test case to verify that SRv6 static SIDs gets programmed correctly from CONFIG_DB to APPL_DB.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
What is the motivation for this PR? Script srv6/test_srv6_static_config.py was added in PR sonic-net#16516, and it fails to run on kvm testbed. We temporarily skip this test in PR testing using conditional mark. How did you do it? We temporarily skip this test in PR testing using conditional mark. How did you verify/test it? Test by pipeline itself to see if this script can be skipped on kvm testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add a control plane test case to verify that SRv6 static SIDs gets programmed correctly from CONFIG_DB to APPL_DB.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Verify the functionality of SRv6 in Control Plane
How did you do it?
Add two test cases to test the configuration of uN and uDT46 SIDs.
How did you verify/test it?
Run it on VS testbed
Any platform specific information?
VS by now
Supported testbed topology if it's a new test case?
T0 only by now
Documentation