[FRR]: Verifying static SRv6 SIDs parameters#21467
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 21, 2025
Merged
Conversation
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@cscarpitta : Please add some PR description. Also are these changes already in FRR mainline ? |
ahsalam
approved these changes
Jan 20, 2025
Contributor
Author
Hi @abdosi thanks for the review. I updated the PR description. |
11 tasks
Contributor
|
local cherry-pick looks good. retry labeling this PR. |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#542 |
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 25, 2025
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 25, 2025
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 25, 2025
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 26, 2025
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 26, 2025
As of sonic-net/sonic-buildimage#21467 some tests are failing due to a validation that `block-len+node-len = locator-len`. However in some of the test cases this wasn't actually true, meaning the tests were invalid as designed. Update the test cases to be valid by this logic. Should also universally wait for interface deletion at tear down to make sure it doesn't cause failures in the next test. Signed-off-by: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FRR CLI to support SRv6 Static SIDs has been merged in FRR mainline in this PR (FRRouting/frr#16894). The CLI has been ported into SONiC mainline in this PR (#21380).
This PR verifies the SRv6 Static SIDs configured by the above FRR CLI. It verifies that the block and node parts of the configured SID matches block and node parts of the locator it belongs to. The PR computes the parameters that will be installed with the SID into APPL DB. The changes in this PR will be also added into FRR mainline.