Skip to content

Update background traffic to make pfcwd timer accuracy test more stable #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingwang-ms merged 1 commit into from
Jul 3, 2025
Merged

Update background traffic to make pfcwd timer accuracy test more stable #16300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/pfcwd/test_pfcwd_timer_accuracy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def run_test(self, setup_info):
test_ports_info = setup_info['test_ports']
queues = [self.storm_handle.pfc_queue_idx]

with send_background_traffic(self.dut, self.ptf, queues, selected_test_ports, test_ports_info):
with send_background_traffic(self.dut, self.ptf, queues, selected_test_ports, test_ports_info, pkt_count=500):
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the function doesn't take the parameter pkt_count?

sonic-mgmt/tests/common/helpers/pfcwd_helper.py

Line 492 in 0028a82

def send_background_traffic(duthost, ptfhost, storm_hndle, selected_test_ports, test_ports_info):

Copy link
Copy Markdown
Contributor Author

@echuawu echuawu Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should based on the PR #15870

self.storm_handle.start_storm()
logger.info("Wait for queue to recover from PFC storm")
time.sleep(32)
Expand Down
Loading