Skip to content

Update background traffic to make pfcwd timer accuracy test more stable#16300

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:dualtor_pfcwd_background
Jul 3, 2025
Merged

Update background traffic to make pfcwd timer accuracy test more stable#16300
bingwang-ms merged 1 commit intosonic-net:masterfrom
echuawu:dualtor_pfcwd_background

Conversation

@echuawu
Copy link
Copy Markdown
Contributor

@echuawu echuawu commented Jan 2, 2025

Description of PR

Update background traffic to make pfcwd timer accuracy test more stable on SN4700 dualtor aa setup with hwsku Mellanox-SN4700-V64

Summary:
Fixes # (issue)
PFCWD accurency test failure

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

PFCWD accurency test failure on SN4700 dualtor aa setup with hwsku Mellanox-SN4700-V64

How did you do it?

Adjust the background traffic

How did you verify/test it?

Run it in local setup

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Copy Markdown
Contributor Author

echuawu commented Jan 3, 2025

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu echuawu force-pushed the dualtor_pfcwd_background branch from 6f5d4b5 to cf13af3 Compare January 6, 2025 02:49
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu echuawu force-pushed the dualtor_pfcwd_background branch from cf13af3 to 7e97950 Compare January 8, 2025 03:00
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

queues = [self.storm_handle.pfc_queue_idx]

with send_background_traffic(self.dut, self.ptf, queues, selected_test_ports, test_ports_info):
with send_background_traffic(self.dut, self.ptf, queues, selected_test_ports, test_ports_info, pkt_count=500):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the function doesn't take the parameter pkt_count?

def send_background_traffic(duthost, ptfhost, storm_hndle, selected_test_ports, test_ports_info):

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should based on the PR #15870

@bingwang-ms
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Copy Markdown
Contributor Author

echuawu commented Jun 24, 2025

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@congh-nvidia
Copy link
Copy Markdown
Contributor

@echuawu please check the PR failure.

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
auto-merge was automatically disabled June 26, 2025 09:09

Head branch was pushed to by a user without write access

@echuawu echuawu force-pushed the dualtor_pfcwd_background branch from 7e97950 to 8827ddd Compare June 26, 2025 09:09
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nhe-NV
Copy link
Copy Markdown
Contributor

nhe-NV commented Jun 26, 2025

@bingwang-ms Can you help to review and merge the PR, it could make the testcase stable on the dualtor setup.

@bingwang-ms bingwang-ms merged commit 5497a2a into sonic-net:master Jul 3, 2025
13 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 3, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #19395

mssonicbld pushed a commit that referenced this pull request Jul 3, 2025
…le (#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 3, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202411: #19401

nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
mssonicbld pushed a commit that referenced this pull request Aug 25, 2025
…le (#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Signed-off-by: Guy Shemesh <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
…le (sonic-net#16300)

Update background traffic to make pfcwd timer accuracy test more stable

Change-Id: I2d3146b4bd1a0601e4cfed3c5044381577504dcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants