Fix unexpected exception in wait_for while executing reboot by ZhaohuiS · Pull Request #16085 · sonic-net/sonic-mgmt

ZhaohuiS · 2024-12-16T08:08:20Z

Description of PR

Summary:
Fixes # (issue)
platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error:

TypeError: unsupported type for timedelta seconds component: NoneType

in the following error test log:

Traceback (most recent call last):
  File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module>
    _ansiballz_main()
  File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module
    runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path),
  File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code
    exec(code, run_globals)
  File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module>
  File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main
TypeError: unsupported type for timedelta seconds component: NoneType
",
  "msg": "MODULE FAILURE
See stdout/stderr for the exact error",

That because timeout parameter is set to None for localhost.wait_for function.

The change was made in #15951

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for.

How did you do it?

Don't pass in timeout if it's not module chassis

How did you verify/test it?

Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed.

Any platform specific information?

T0/T1/M0/Mx

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

mssonicbld · 2024-12-16T08:08:23Z

/azp run

azure-pipelines · 2024-12-16T08:08:36Z

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms · 2024-12-17T02:46:34Z

We can set the default value to 0. The code will set the value if timeout == 0

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

mssonicbld · 2024-12-18T02:00:00Z

/azp run

ZhaohuiS · 2024-12-18T02:00:55Z

We can set the default value to 0. The code will set the value if timeout == 0
Thank you for the reminder, I set timeout to 0 instead of removing it.

azure-pipelines · 2024-12-18T02:00:59Z

Azure Pipelines successfully started running 1 pipeline(s).

auspham

Thanks for taking care of this

yejianquan · 2024-12-18T04:06:56Z

/azp run

azure-pipelines · 2024-12-18T04:07:08Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS · 2024-12-18T10:30:13Z

@yejianquan could you please help merge it?

yejianquan · 2024-12-18T10:34:14Z

@yejianquan could you please help merge it?

merged, thanks for the quick fix!

…t#16085) Description of PR Summary: Fixes # (issue) platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error: TypeError: unsupported type for timedelta seconds component: NoneType in the following error test log: Traceback (most recent call last): File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module> _ansiballz_main() File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path), File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code exec(code, run_globals) File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module> File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main TypeError: unsupported type for timedelta seconds component: NoneType ", "msg": "MODULE FAILURE See stdout/stderr for the exact error", That because timeout parameter is set to None for localhost.wait_for function. The change was made in sonic-net#15951 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for. How did you do it? Don't pass in timeout if it's not module chassis How did you verify/test it? Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed. Any platform specific information? Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

mssonicbld · 2024-12-18T10:34:43Z

Cherry-pick PR to 202405: #16138

Description of PR Summary: Fixes # (issue) platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error: TypeError: unsupported type for timedelta seconds component: NoneType in the following error test log: Traceback (most recent call last): File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module> _ansiballz_main() File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path), File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code exec(code, run_globals) File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module> File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main TypeError: unsupported type for timedelta seconds component: NoneType ", "msg": "MODULE FAILURE See stdout/stderr for the exact error", That because timeout parameter is set to None for localhost.wait_for function. The change was made in #15951 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for. How did you do it? Don't pass in timeout if it's not module chassis How did you verify/test it? Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed. Any platform specific information? Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

StormLiangMS · 2025-01-23T04:13:57Z

hi @ZhaohuiS seems can't start the auto cherry pick, could you manually file one to 202411?

Fix unexpected exception in wait_for while executing reboot

f132180

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

ZhaohuiS requested a review from prgeor as a code owner December 16, 2024 08:08

change default timeout to 0

0882bed

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

auspham approved these changes Dec 18, 2024

View reviewed changes

auspham added the Request for 202405 branch label Dec 18, 2024

yejianquan merged commit 5b619d4 into sonic-net:master Dec 18, 2024

yejianquan added the Approved for 202405 branch label Dec 18, 2024

mssonicbld added the Created PR to 202405 branch label Dec 18, 2024

mssonicbld mentioned this pull request Dec 18, 2024

[action] [PR:16085] Fix unexpected exception in wait_for while executing reboot #16138

Merged

8 tasks

mssonicbld added Included in 202405 branch and removed Created PR to 202405 branch labels Dec 18, 2024

StormLiangMS added Approved for 202411 branch Request for 202411 branch and removed Approved for 202411 branch labels Jan 22, 2025

ZhaohuiS mentioned this pull request Jan 23, 2025

[202411] Fix unexpected exception in wait_for while executing reboot #16644

Merged

11 tasks

Conversation

ZhaohuiS commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Dec 16, 2024

Uh oh!

azure-pipelines bot commented Dec 16, 2024

Uh oh!

bingwang-ms commented Dec 17, 2024

Uh oh!

mssonicbld commented Dec 18, 2024

Uh oh!

ZhaohuiS commented Dec 18, 2024

Uh oh!

azure-pipelines bot commented Dec 18, 2024

Uh oh!

auspham left a comment

Choose a reason for hiding this comment

Uh oh!

yejianquan commented Dec 18, 2024

Uh oh!

azure-pipelines bot commented Dec 18, 2024

Uh oh!

ZhaohuiS commented Dec 18, 2024

Uh oh!

yejianquan commented Dec 18, 2024

Uh oh!

mssonicbld commented Dec 18, 2024

Uh oh!

StormLiangMS commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhaohuiS commented Dec 16, 2024 •

edited

Loading