Adjust t2 timing in tests/platform_tests/test_reload_config.py by auspham · Pull Request #15951 · sonic-net/sonic-mgmt

auspham · 2024-12-09T04:55:38Z

Description of PR

Summary:
Fixes # (issue) 3045798

The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time.

By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300

https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133

For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly.

This PR will fix that

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

Enable plt_reboot_ctrl_overwrite if platform is T2

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Austin Pham <austinpham@microsoft.com>

yejianquan

LGTM

…onic-net#15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in sonic-net#13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

mssonicbld · 2024-12-11T01:05:20Z

Cherry-pick PR to 202405: #15993

…15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

bingwang-ms · 2024-12-17T23:38:37Z

This PR causes regression on Non-chassis platform because timeout is set to None by default. The default value should be 0.

auspham · 2024-12-17T23:54:40Z

This PR causes regression on Non-chassis platform because timeout is set to None by default. The default value should be 0.

Thanks for pointing out, timeout should be set to 0 instead of None.

Description of PR Summary: Fixes # (issue) platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error: TypeError: unsupported type for timedelta seconds component: NoneType in the following error test log: Traceback (most recent call last): File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module> _ansiballz_main() File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path), File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code exec(code, run_globals) File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module> File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main TypeError: unsupported type for timedelta seconds component: NoneType ", "msg": "MODULE FAILURE See stdout/stderr for the exact error", That because timeout parameter is set to None for localhost.wait_for function. The change was made in #15951 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for. How did you do it? Don't pass in timeout if it's not module chassis How did you verify/test it? Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed. Any platform specific information? Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

…t#16085) Description of PR Summary: Fixes # (issue) platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error: TypeError: unsupported type for timedelta seconds component: NoneType in the following error test log: Traceback (most recent call last): File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module> _ansiballz_main() File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path), File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code exec(code, run_globals) File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module> File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main TypeError: unsupported type for timedelta seconds component: NoneType ", "msg": "MODULE FAILURE See stdout/stderr for the exact error", That because timeout parameter is set to None for localhost.wait_for function. The change was made in sonic-net#15951 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for. How did you do it? Don't pass in timeout if it's not module chassis How did you verify/test it? Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed. Any platform specific information? Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

Description of PR Summary: Fixes # (issue) platform_tests/test_reload_config.py::test_reload_configuration_checks failed due to the following error: TypeError: unsupported type for timedelta seconds component: NoneType in the following error test log: Traceback (most recent call last): File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 107, in <module> _ansiballz_main() File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 99, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/tmp/.ansible-AzDevOps/ansible-tmp-1734119665.955616-147727-226449133302882/AnsiballZ_wait_for.py\", line 47, in invoke_module runpy.run_module(mod_name='ansible.modules.wait_for', init_globals=dict(_module_fqn='ansible.modules.wait_for', _modlib_path=modlib_path), File \"/usr/lib/python3.8/runpy.py\", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/usr/lib/python3.8/runpy.py\", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/usr/lib/python3.8/runpy.py\", line 87, in _run_code exec(code, run_globals) File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 689, in <module> File \"/tmp/ansible_wait_for_payload_9brlx4xp/ansible_wait_for_payload.zip/ansible/modules/wait_for.py\", line 544, in main TypeError: unsupported type for timedelta seconds component: NoneType ", "msg": "MODULE FAILURE See stdout/stderr for the exact error", That because timeout parameter is set to None for localhost.wait_for function. The change was made in #15951 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Fix the TypeError: unsupported type for timedelta seconds component: NoneType for localhost.wait_for. How did you do it? Don't pass in timeout if it's not module chassis How did you verify/test it? Run platform_tests/test_reload_config.py::test_reload_configuration_checks on non T2 testbed. Any platform specific information? Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>

…onic-net#15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in sonic-net#13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

mssonicbld · 2025-01-02T01:25:27Z

Cherry-pick PR to 202411: #16284

…15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham requested a review from prgeor as a code owner December 9, 2024 04:55

auspham assigned yejianquan and cyw233 Dec 9, 2024

auspham requested review from cyw233 and yejianquan December 9, 2024 04:56

auspham assigned auspham and unassigned yejianquan and cyw233 Dec 9, 2024

auspham added the Request for 202405 branch label Dec 9, 2024

auspham requested a review from augusdn December 9, 2024 04:56

yejianquan marked this pull request as draft December 9, 2024 07:58

chore: toggle plt_reboot_ctrl_overwrite to increase timeout for t2

ec18ca4

Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham force-pushed the austinpham/30457598-fix-flaky-test-reload-config branch from 5322159 to ec18ca4 Compare December 10, 2024 09:32

auspham changed the title ~~Toggle plt_reboot_ctrl_overwrite to increase timeout for t2 in tests/platform_tests/test_reload_config.py~~ Adjust t2 timing in tests/platform_tests/test_reload_config.py Dec 10, 2024

auspham marked this pull request as ready for review December 10, 2024 21:57

yejianquan approved these changes Dec 11, 2024

View reviewed changes

yejianquan merged commit 12caaa8 into sonic-net:master Dec 11, 2024

yejianquan added the Approved for 202405 branch label Dec 11, 2024

mssonicbld added the Created PR to 202405 branch label Dec 11, 2024

mssonicbld mentioned this pull request Dec 11, 2024

[action] [PR:15951] Adjust t2 timing in tests/platform_tests/test_reload_config.py #15993

Merged

8 tasks

mssonicbld added Included in 202405 branch and removed Created PR to 202405 branch labels Dec 11, 2024

ZhaohuiS mentioned this pull request Dec 16, 2024

Fix unexpected exception in wait_for while executing reboot #16085

Merged

8 tasks

bingwang-ms mentioned this pull request Dec 17, 2024

[platform_tests/test_reload_config]: Respect overridden timeout #16031

Merged

6 tasks

mssonicbld mentioned this pull request Dec 18, 2024

[action] [PR:16085] Fix unexpected exception in wait_for while executing reboot #16138

Merged

8 tasks

sdszhang added Request for 202411 branch Approved for 202411 branch labels Jan 2, 2025

mssonicbld added the Created PR to 202411 branch label Jan 2, 2025

mssonicbld mentioned this pull request Jan 2, 2025

[action] [PR:15951] Adjust t2 timing in tests/platform_tests/test_reload_config.py #16284

Merged

8 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust t2 timing in tests/platform_tests/test_reload_config.py#15951

Adjust t2 timing in tests/platform_tests/test_reload_config.py#15951
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/30457598-fix-flaky-test-reload-config

auspham commented Dec 9, 2024 •

edited

Loading

Uh oh!

yejianquan left a comment

Uh oh!

mssonicbld commented Dec 11, 2024

Uh oh!

bingwang-ms commented Dec 17, 2024

Uh oh!

auspham commented Dec 17, 2024

Uh oh!

mssonicbld commented Jan 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

auspham commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

yejianquan left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 11, 2024

Uh oh!

bingwang-ms commented Dec 17, 2024

Uh oh!

auspham commented Dec 17, 2024

Uh oh!

mssonicbld commented Jan 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

auspham commented Dec 9, 2024 •

edited

Loading