Skip to content

[action] [PR:15949] fix: fix port does not exist error test_bgp_queue#16008

Merged
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/15949
Dec 11, 2024
Merged

[action] [PR:15949] fix: fix port does not exist error test_bgp_queue#16008
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/15949

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue) 30457143

Currently this is using the old method of capturing queue counters:

sudo ip netns exec asic1 show queue counters Ethernet128

This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why)

However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead

Tested by running manual commands

admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128
Port doesn't exist! Ethernet128
admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1
For namespace asic1:
 Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes
----------- ----- -------------- --------------- ----------- ------------
Ethernet128 UC0 0 0 0 0
...

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

Update the test to use new APIs that support -n

How did you verify/test it?

Manually run, needs to verify with available testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Description of PR
Summary:
Fixes # (issue) 30457143

Currently this is using the old method of capturing queue counters:

sudo ip netns exec asic1 show queue counters Ethernet128
This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why)

However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead

Tested by running manual commands

admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128
Port doesn't exist! Ethernet128
admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1
For namespace asic1:
       Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
-----------  -----  --------------  ---------------  -----------  ------------
Ethernet128    UC0               0                0            0             0
...
Type of change

Approach
What is the motivation for this PR?
How did you do it?
Update the test to use new APIs that support -n

How did you verify/test it?
Manually run, needs to verify with available testbed.

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #15949

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d092022 into sonic-net:202405 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants