fix: fix port does not exist error test_bgp_queue by auspham · Pull Request #15949 · sonic-net/sonic-mgmt

auspham · 2024-12-09T03:23:38Z

Description of PR

Summary:
Fixes # (issue) 30457143

Currently this is using the old method of capturing queue counters:

sudo ip netns exec asic1 show queue counters Ethernet128

This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why)

However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead

Tested by running manual commands

admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128
Port doesn't exist! Ethernet128

admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1
For namespace asic1:
       Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
-----------  -----  --------------  ---------------  -----------  ------------
Ethernet128    UC0               0                0            0             0
...

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

Update the test to use new APIs that support -n

How did you verify/test it?

Manually run, needs to verify with available testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Austin Pham <[email protected]>

auspham · 2024-12-10T09:06:30Z

Hi @vmittal-msft @arista-hpandya, could you please help advise if this is an acceptable solution for this problem? Thanks

yejianquan · 2024-12-10T10:52:07Z

Hi @auspham Discussed with Abhishek, it's ok to use the new way only, nowhere is using the old way

arista-hpandya · 2024-12-10T18:56:20Z

@auspham I have left a detailed comment in sonic-net/sonic-utilities#3554. Hopefully that clarifies it further!

yejianquan · 2024-12-11T02:28:39Z

tests/common/devices/sonic_asic.py

            return self.sonichost.command(cmdstr)

-        cmdstr = "sudo ip netns exec {} {}".format(self.namespace, cmdstr)
+        if new_format:


Since this change will go to 202405 branch
Could you please confirm the new format works well on single ASIC devices?

@yejianquan passed single-asic 202405 image

auspham · 2024-12-11T03:45:30Z

Verified in both single and multi-asic with newest 202405 build image

Single-asic:

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
- generated xml file: /var/src/sonic-mgmt_vms12-t0-7060x6-2_672af7fbc5c63d1d662894a7/tests/logs/bgp/test_bgp_queue.xml -
================== 1 passed, 4 warnings in 322.81s (0:05:22) ===================

multi-asic

sonic-mgmt_vms69-t2-8800-1_66b4a53de4614bccc2e74f8c/tests/logs/bgp/test_bgp_queue.xml -
================== 9 passed, 1 warning in 2589.36s (0:43:09) ===================

yejianquan

LGTM

Description of PR Summary: Fixes # (issue) 30457143 Currently this is using the old method of capturing queue counters: sudo ip netns exec asic1 show queue counters Ethernet128 This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why) However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead Tested by running manual commands admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128 Port doesn't exist! Ethernet128 admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1 For namespace asic1: Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes ----------- ----- -------------- --------------- ----------- ------------ Ethernet128 UC0 0 0 0 0 ... Type of change Approach What is the motivation for this PR? How did you do it? Update the test to use new APIs that support -n How did you verify/test it? Manually run, needs to verify with available testbed. Signed-off-by: Austin Pham <[email protected]>

mssonicbld · 2024-12-11T06:05:19Z

Cherry-pick PR to 202405: #16008

Description of PR Summary: Fixes # (issue) 30457143 Currently this is using the old method of capturing queue counters: sudo ip netns exec asic1 show queue counters Ethernet128 This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why) However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead Tested by running manual commands admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128 Port doesn't exist! Ethernet128 admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1 For namespace asic1: Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes ----------- ----- -------------- --------------- ----------- ------------ Ethernet128 UC0 0 0 0 0 ... Type of change Approach What is the motivation for this PR? How did you do it? Update the test to use new APIs that support -n How did you verify/test it? Manually run, needs to verify with available testbed. Signed-off-by: Austin Pham <[email protected]>

mssonicbld · 2025-01-02T01:25:54Z

Cherry-pick PR to 202411: #16286

Description of PR Summary: Fixes # (issue) 30457143 Currently this is using the old method of capturing queue counters: sudo ip netns exec asic1 show queue counters Ethernet128 This will throw an issue with some testbed and says Ethernet128 does not exists. (haven't had chance to confirm why) However since we have new support for -n sonic-net/sonic-utilities#2439 we should be using this instead Tested by running manual commands admin@str3-8800-lc4-1:~$ sudo ip netns exec asic1 show queue counters Ethernet128 Port doesn't exist! Ethernet128 admin@str3-8800-lc4-1:~$ show queue counters Ethernet128 -n asic1 For namespace asic1: Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes ----------- ----- -------------- --------------- ----------- ------------ Ethernet128 UC0 0 0 0 0 ... Type of change Approach What is the motivation for this PR? How did you do it? Update the test to use new APIs that support -n How did you verify/test it? Manually run, needs to verify with available testbed. Signed-off-by: Austin Pham <[email protected]>

auspham requested a review from StormLiangMS as a code owner December 9, 2024 03:23

auspham added the Request for 202405 branch label Dec 9, 2024

auspham requested a review from yejianquan December 9, 2024 03:23

auspham force-pushed the austinpham/30457143-resolve-bgp-test-bgp-queue branch from 5d53fb8 to 34c91ed Compare December 9, 2024 06:47

yejianquan marked this pull request as draft December 9, 2024 07:08

auspham force-pushed the austinpham/30457143-resolve-bgp-test-bgp-queue branch from 34c91ed to 32aab07 Compare December 10, 2024 09:03

fix: fix port does not exist error test_bgp_queue

64d8cff

Signed-off-by: Austin Pham <[email protected]>

auspham force-pushed the austinpham/30457143-resolve-bgp-test-bgp-queue branch from 32aab07 to 64d8cff Compare December 10, 2024 09:04

auspham mentioned this pull request Dec 10, 2024

Fix multi-asic behaviour for queuestat sonic-net/sonic-utilities#3554

Merged

auspham marked this pull request as ready for review December 10, 2024 23:19

yejianquan reviewed Dec 11, 2024

View reviewed changes

yejianquan approved these changes Dec 11, 2024

View reviewed changes

yejianquan merged commit 4e48542 into sonic-net:master Dec 11, 2024

yejianquan added the Approved for 202405 branch label Dec 11, 2024

mssonicbld added the Created PR to 202405 branch label Dec 11, 2024

mssonicbld mentioned this pull request Dec 11, 2024

[action] [PR:15949] fix: fix port does not exist error test_bgp_queue #16008

Merged

8 tasks

mssonicbld added Included in 202405 branch and removed Created PR to 202405 branch labels Dec 11, 2024

sdszhang added Request for 202411 branch Approved for 202411 branch labels Jan 2, 2025

mssonicbld added the Created PR to 202411 branch label Jan 2, 2025

mssonicbld mentioned this pull request Jan 2, 2025

[action] [PR:15949] fix: fix port does not exist error test_bgp_queue #16286

Merged

8 tasks

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Jan 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix port does not exist error test_bgp_queue#15949

fix: fix port does not exist error test_bgp_queue#15949
yejianquan merged 1 commit intosonic-net:masterfrom
auspham:austinpham/30457143-resolve-bgp-test-bgp-queue

auspham commented Dec 9, 2024 •

edited

Loading

Uh oh!

auspham commented Dec 10, 2024

Uh oh!

yejianquan commented Dec 10, 2024

Uh oh!

arista-hpandya commented Dec 10, 2024

Uh oh!

yejianquan Dec 11, 2024

Uh oh!

auspham Dec 11, 2024

Uh oh!

auspham commented Dec 11, 2024

Uh oh!

yejianquan left a comment

Uh oh!

mssonicbld commented Dec 11, 2024

Uh oh!

mssonicbld commented Jan 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

auspham commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

auspham commented Dec 10, 2024

Uh oh!

yejianquan commented Dec 10, 2024

Uh oh!

arista-hpandya commented Dec 10, 2024

Uh oh!

yejianquan Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

auspham Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

auspham commented Dec 11, 2024

Uh oh!

yejianquan left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 11, 2024

Uh oh!

mssonicbld commented Jan 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

auspham commented Dec 9, 2024 •

edited

Loading