Refactor function get_iface_ip to common location#15893
Merged
wangxin merged 1 commit intosonic-net:masterfrom Dec 5, 2024
Merged
Refactor function get_iface_ip to common location#15893wangxin merged 1 commit intosonic-net:masterfrom
get_iface_ip to common location#15893wangxin merged 1 commit intosonic-net:masterfrom
Conversation
7 tasks
echuawu
approved these changes
Dec 5, 2024
wangxin
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In PR #15619, a cross-feature dependency was introduced in
tests/acl/test_acl.pydue to the usage of theget_iface_ipfunction. To address this issue and streamline the code structure, we have refactored the function and moved it to a common location.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In PR #15619, a cross-feature dependency was introduced in
tests/acl/test_acl.pydue to the usage of theget_iface_ipfunction. To address this issue and streamline the code structure, we have refactored the function and moved it to a common location.How did you do it?
To address this issue and streamline the code structure, we have refactored the function and moved it to a common location.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation