Update acl test case to permit nic simulator keepalive path in dualtor-aa topology.#15619
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Dec 3, 2024
Merged
Conversation
Permit nic simulator keepalive path Change-Id: I32212d2bf9406efe1228ede7e8083aff44fb2b2f
nhe-NV
approved these changes
Nov 19, 2024
liat-grozovik
approved these changes
Dec 3, 2024
liat-grozovik
changed the title
bingwang-ms
reviewed
Dec 4, 2024
| # TODO: We really shouldn't have two separate templates for v4 and v6, need to combine them somehow | ||
| ACL_RULES_FULL_TEMPLATE = { | ||
| "ipv4": "acltb_test_rules.j2", | ||
| "ipv4": "acltb_test_rules_permit_loopback.j2", |
Collaborator
There was a problem hiding this comment.
Why not add the loopback ACL rule to the original file?
Contributor
Author
There was a problem hiding this comment.
Hi @bingwang-ms , the acltb_test_rules.j2 has been shared by tests/ssh/test_ssh_stress.py too, if keep the change in the original file, it would affect tests/ssh/test_ssh_stress.py.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 4, 2024
…r-aa topology. (sonic-net#15619) - How did you do it? Permit nic simulator keepalive path in dualtor-aa topology - How did you verify/test it? Run it in internal dualtor regression.
Collaborator
|
Cherry-pick PR to 202405: #15866 |
7 tasks
| from tests.common.fixtures.conn_graph_facts import conn_graph_facts # noqa F401 | ||
| from tests.common.platform.processes_utils import wait_critical_processes | ||
| from tests.common.platform.interface_utils import check_all_interface_information | ||
| from tests.qos.tunnel_qos_remap_base import get_iface_ip |
Contributor
There was a problem hiding this comment.
Hi, @echuawu, there are cross feature dependency, which means, we are not allowed to import functions from tests/qos in tests/acl, can you fix this issue?
Contributor
Author
There was a problem hiding this comment.
Hi, @echuawu, there are cross feature dependency, which means, we are not allowed to import functions from
tests/qosintests/acl, can you fix this issue?
Hi @yutongzhang-microsoft , is it proper to define a get_iface_ip function in test_acl.py?
Contributor
There was a problem hiding this comment.
I think you can.
8 tasks
Contributor
Contributor
Author
wangxin
pushed a commit
that referenced
this pull request
Dec 5, 2024
What is the motivation for this PR? In PR #15619, a cross-feature dependency was introduced in tests/acl/test_acl.py due to the usage of the get_iface_ip function. To address this issue and streamline the code structure, we have refactored the function and moved it to a common location. How did you do it? To address this issue and streamline the code structure, we have refactored the function and moved it to a common location. How did you verify/test it?
mssonicbld
pushed a commit
that referenced
this pull request
Jan 21, 2025
…r-aa topology. (#15619) - How did you do it? Permit nic simulator keepalive path in dualtor-aa topology - How did you verify/test it? Run it in internal dualtor regression.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
ansrajpu-git
pushed a commit
to ansrajpu-git/sonic-mgmt
that referenced
this pull request
Apr 14, 2025
…n dualtor-aa topology. (sonic-net#15619)" This reverts commit cdab08e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update acl test case to permit nic simulator keepalive path in dualtor-aa topology.
Summary:
Fixes # (issue)
#15206
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix - #15206
How did you do it?
Permit nic simulator keepalive path in dualtor-aa topology
How did you verify/test it?
Run it in internal dualtor regression.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation