Add a suffix to the testcase logfile #14885
Merged
kevinskwang merged 1 commit intosonic-net:202405from Oct 22, 2024
Merged
Conversation
8 tasks
Contributor
|
Why does this not go to master branch? |
Contributor
Author
@wsycqyz this PR has been spun out of #14803 as requested by @kevinskwang. This change is already present in master |
Contributor
Author
|
@kevinskwang please check |
kevinskwang
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add support to provide a suffix to the test case log file name.
this will be useful in test cases where there are multiple runs with different combinations
being invoked and each run can be logged as a separate log file for easier tracking.
How did you do it?
Added log_suffix as a dict key to testParams
How did you verify/test it?
Ran it as part of FullMeshTrafficSanitytestcase #11968
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation