Skip to content

Full Mesh Traffic Sanity verification #14803

Merged
kevinskwang merged 3 commits intosonic-net:202405from
sreejithsreekumaran:conditional_mark_fix_revert
Oct 22, 2024
Merged

Full Mesh Traffic Sanity verification #14803
kevinskwang merged 3 commits intosonic-net:202405from
sreejithsreekumaran:conditional_mark_fix_revert

Conversation

@sreejithsreekumaran
Copy link
Copy Markdown
Contributor

@sreejithsreekumaran sreejithsreekumaran commented Sep 30, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

ptf64 topology is used to have 64 ports of the DUT connected
to 64 PTF ports.

How did you verify/test it?

Ran the test on a T1 ptf-64 topology

Any platform specific information?

This is a Cisco specific test case

Supported testbed topology if it's a new test case?

Documentation

@kevinskwang
Copy link
Copy Markdown
Contributor

@sreejithsreekumaran please fill all the sections of the commit message

@sreejithsreekumaran
Copy link
Copy Markdown
Contributor Author

@sreejithsreekumaran please fill all the sections of the commit message

Please check. I have updated now

@sreejithsreekumaran
Copy link
Copy Markdown
Contributor Author

New PR #14885 for logfile suffix.

def get_tcp_port():
val = 1234
while True:
if val == 65535:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to remove this line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinskwang Strange, I got email notification only today for this comment.

  • The modulo operation ((val + 10) % 65535) will always yield values between 0 and 65534. Hence, val will never actually reach 65535.

  • The updated logic where the ports reset to 1234 after reaching 65534 is for our requirement of needing an infinite supply of ports. This approach effectively reuses port numbers in a cyclic manner, ensuring that we always have ports available without hitting a hard limit, which is crucial in scenarios like full-mesh traffic sanity testing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinskwang please confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants