Refactor pfcwd_helpers.py from folder tests/pfcwd to tests/common/helpers#14580
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Sep 14, 2024
Conversation
yutongzhang-microsoft
deleted the
yutongzhang/refactor_pfcwd_helpers
branch
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…n/helpers` (sonic-net#14580) What is the motivation for this PR? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers.
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…n/helpers` (sonic-net#14580) What is the motivation for this PR? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers.
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
…n/helpers` (sonic-net#14580) What is the motivation for this PR? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers. How did you do it? Some scripts use the shared functions in pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific folder tests/pfcwd to common folder tests/common/helpers.
auspham
added a commit
to auspham/sonic-mgmt
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Austin Pham <austinpham@microsoft.com>
Contributor
|
Hi, @yutongzhang-microsoft , do we need to pick this PR to 202405, thanks |
yejianquan
pushed a commit
that referenced
this pull request
Dec 9, 2024
* add test case for cli show pfcwd stat (#14711) What is the motivation for this PR? #11169 How did you do it? Add a new test case to cover "pfcwd show stats" cmd Trigger PFC storm with action drop or forward send_tx_egress and send_rx_ingress execute CMD 'show pfcwd stat' and ensure the output is expected How did you verify/test it? https://elastictest.org/scheduler/testplan/66f268ae4216a91fd43d97b6 https://elastictest.org/scheduler/testplan/66f268880369ccd340b3ea60 * chore: fix conflict with #14580 Signed-off-by: Austin Pham <austinpham@microsoft.com> --------- Signed-off-by: Austin Pham <austinpham@microsoft.com> Co-authored-by: Liping Xu <108326363+lipxu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some scripts use the shared functions in
pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/pfcwdto common foldertests/common/helpers.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Some scripts use the shared functions in
pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/pfcwdto common foldertests/common/helpers.How did you do it?
Some scripts use the shared functions in
pfcwd_helpers.py. To minimize cross-module dependencies, we move this helper script from feature specific foldertests/pfcwdto common foldertests/common/helpers.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation